1640985 - rust 1.45 must-use error about mem::replace in calc.rs

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[(Away)]

1:34.65    --> servo\components\style\values\generics\calc.rs:340:17
 1:34.65     |
 1:34.65 340 |                 mem::replace(self, result);
 1:34.65     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^
 1:34.65 ...
 1:34.65 386 |                     return replace_self_with!(&mut **max);
 1:34.65     |                            ------------------------------ in this macro invocation
 1:34.65     |
 1:34.65     = note: if you don't need the old value, you can just assign the new value directly

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1640985 - Remove two useless mem::replace calls. r=#style

Comment 2

[Erik Nordin [:nordzilla]]

Marking this as normal severity, as it looks like it's already handled.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6cc8ef8beb30
Remove two useless mem::replace calls. r=boris

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/6cc8ef8beb30