Closed Bug 1641058 Opened 6 months ago Closed 5 months ago

tasks that only exist because of another that is later optimized away should not be scheduled

Categories

(Firefox Build System :: Task Configuration, task)

task

Tracking

(firefox80 fixed)

RESOLVED FIXED
mozilla80
Tracking Status
firefox80 --- fixed

People

(Reporter: bhearsum, Assigned: bhearsum)

References

(Blocks 1 open bug)

Details

(Whiteboard: [ci-costs-2020:todo])

Attachments

(2 files)

While discussing other things, it came up that if task A is included in a target graph only because of task B, and task B is later optimized away, task A will still be scheduled for no reason. It's really difficult to know exactly how often this is happening, but it appears to be pretty common on try and autoland.

From Matrix:
bhearsum: If we pass down the set of tasks that we to generate the target graph (i.e the tasks from https://searchfox.org/mozilla-central/source/taskcluster/taskgraph/generator.py#322 but not the closure thereof) and feed it down to https://searchfox.org/mozilla-central/source/taskcluster/taskgraph/optimize/init.py#121 (via https://searchfox.org/mozilla-central/source/taskcluster/taskgraph/generator.py#340 ) we could unconditionally optimize all tasks that aren't in that set.
I'd definitely worry about unexpected side-effects of doing that, though.
aki
we could maybe log what would have been optimized out, and watch that list over time ?
tom.prince
Sure, lots of stuff we could do; I haven't though through what might be impacted. Mostly I was suggesting do lots of testing of the results before landing.

Assignee: nobody → bhearsum
Status: NEW → ASSIGNED
Pushed by bhearsum@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6a42da21836e
tasks that only exist because of another that is later optimized away should not be scheduled r=tomprince
Pushed by bhearsum@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d445091a0585
tasks that only exist because of another that is later optimized away should not be scheduled r=tomprince
Pushed by dluca@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/10b03f2e2a93
fix unit test failures from remove_tasks interface change. a=fix. CLOSED TREE
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
Flags: needinfo?(bhearsum)
You need to log in before you can comment on or make changes to this bug.