Closed Bug 1641105 Opened 6 years ago Closed 6 years ago

Simplify reloaded event

Categories

(DevTools :: Debugger, task)

task

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 1632141

People

(Reporter: jlast, Unassigned)

References

(Blocks 1 open bug)

Details

What were you doing?

We currently emit the "reloaded" event in the redux navigated action. it'd be simpler if it were emitted in onTargetAvailable in the toolbox.

(In reply to Jason Laster [:jlast] from comment #0)

What were you doing?

We currently emit the "reloaded" event in the redux navigated action. it'd be simpler if it were emitted in onTargetAvailable in the toolbox.

The reloaded event is meant to be triggered when the panel is done processing the new data from the navigation. This is not something that can be handled at toolbox level.

For instance, for the inspector it should be fired when the markup view is fully updated with the content from the new page.
For the debugger I guess it should be fired when the source tree shows the sources that correspond to the new page, breakpoints as well etc...

So it's really panel specific. Also note that it's called reloaded, but it actually corresponds to any navigation.

Julian, what do you think we should do with this ticket?

Flags: needinfo?(jdescottes)

Let's close it for now, there's a bigger discussion to have around navigation/reloading https://bugzilla.mozilla.org/show_bug.cgi?id=1632141

Status: NEW → RESOLVED
Closed: 6 years ago
Flags: needinfo?(jdescottes)
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.