Crash in [@ mozilla::dom::ClientSource::WindowExecutionReady]
Categories
(Core :: DOM: Service Workers, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr68 | --- | unaffected |
firefox76 | --- | unaffected |
firefox77 | --- | unaffected |
firefox78 | --- | fixed |
People
(Reporter: calixte, Assigned: timhuang)
References
(Blocks 1 open bug, Regression)
Details
(Keywords: crash, regression)
Crash Data
Attachments
(4 files)
This bug is for crash report bp-99206295-3ab7-43a2-89b6-bcf280200527.
Top 10 frames of crashing thread:
0 xul.dll mozilla::dom::ClientSource::WindowExecutionReady dom/clients/manager/ClientSource.cpp:265
1 xul.dll nsGlobalWindowInner::ExecutionReady dom/base/nsGlobalWindowInner.cpp:1799
2 xul.dll nsGlobalWindowOuter::SetNewDocument dom/base/nsGlobalWindowOuter.cpp:2391
3 xul.dll nsDocumentViewer::InitInternal layout/base/nsDocumentViewer.cpp:960
4 xul.dll nsDocumentViewer::Init layout/base/nsDocumentViewer.cpp:749
5 xul.dll nsDocShell::SetupNewViewer docshell/base/nsDocShell.cpp:7892
6 xul.dll nsDocShell::Embed docshell/base/nsDocShell.cpp:5494
7 xul.dll nsDocShell::CreateContentViewer docshell/base/nsDocShell.cpp:7702
8 xul.dll nsDSURIContentListener::DoContent docshell/base/nsDSURIContentListener.cpp:181
9 xul.dll nsDocumentOpenInfo::TryContentListener uriloader/base/nsURILoader.cpp:630
There are 26 crashes (from 4 installations) in nightly 78 with buildid 20200526213752. In analyzing the backtrace, the regression may have been introduced by patch [1] to fix bug 1637226.
[1] https://hg.mozilla.org/mozilla-central/rev?node=6cad6edc25ba
Reporter | ||
Updated•5 years ago
|
Assignee | ||
Comment 1•5 years ago
|
||
It seems there are still some cases that could trigger this crash. I need to check this. Set the assertion back to MOZ_ASSERT() first to prevent further crashes.
Assignee | ||
Comment 2•5 years ago
|
||
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 4•5 years ago
|
||
The crash happens when we load a nested iframe who has registered a service worker and has the storage access. It's because we don't check if the iframe is nested in the channel check but we do it in the window check. So, the nested iframe would get access from the channel check but get blocked by the window check, which causes this crash. We should check if the iframe is nested for the channel check as well.
Updated•5 years ago
|
Assignee | ||
Comment 5•5 years ago
|
||
Assignee | ||
Comment 6•5 years ago
|
||
We should check the nested iframe in the
ContentBlocking::ShouldAllowAccessFor(channel) as well. This patch
implements this.
Depends on D77074
Assignee | ||
Comment 7•5 years ago
|
||
Depends on D77075
Comment 8•5 years ago
|
||
bugherder |
Assignee | ||
Updated•5 years ago
|
Comment 10•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/5a7e4520064c
https://hg.mozilla.org/mozilla-central/rev/b0959ede7962
https://hg.mozilla.org/mozilla-central/rev/df38944a433e
Updated•5 years ago
|
Description
•