1641161 - Preparation for Linearize AudioContextOperation resolution

Status: RESOLVED FIXED

(Core :: Audio/Video: MediaStreamGraph, task)

Description

[Karl Tomlinson (:karlt)]

Some clean-up to prepare for fixing bug 1285290.

Comment 1

[Karl Tomlinson (:karlt)]

Attachment: Bug 1285290 set prefs on two crashtests to allow autoplay r?padenot

Apparently this pref is already set when the tests are run on CI,
but it is not being set when running a single test or subdir.

Comment 2

[Karl Tomlinson (:karlt)]

Attachment: Bug 1285290 don't add destroyed tracks to graph from Increment/DecrementSuspendCount r?padenot

Tracks remove themselves from the graph after DestroyImpl() and so should not
be added again after this.

These methods are now invoked only on the MediaTrack removing the possibility
of calling the wrong method.

Depends on D76797

Comment 3

[Karl Tomlinson (:karlt)]

Attachment: Bug 1285290 move AudioContextOperationControlMessage out of function scope r?padenot

This will permit passing an AudioContextOperationControlMessage* to other
methods.

Depends on D76798

Comment 4

[Karl Tomlinson (:karlt)]

Attachment: Bug 1285290 alias move() to std::move() in MediaTrackGraph.cpp and AudioContext.cpp r?padenot

Depends on D76799

Comment 5

[Karl Tomlinson (:karlt)]

Attachment: Bug 1285290 move code to choose the next GraphDriver to CheckDriver() r?padenot

There is a small logic change here when
!audioTrackPresent && audioCallbackDriver && !IsStarted() &&
graphOutputChannelCount != audioCallbackDriver->OutputChannelCount()
Now, no driver change is scheduled in that situation.

Depends on D76802

Comment 6

[Karl Tomlinson (:karlt)]

Attachment: Bug 1285290 Document suspend/resume accounting wrt ApplyAudioContextOperation() r?padenot

Depends on D76803

Comment 7

[Karl Tomlinson (:karlt)]

Attachment: Bug 1641161 remove some graph-thread LIFECYCLE_RUNNING conditions r?padenot

On the graph thread, mLifecycleState is known to be LIFECYCLE_RUNNING.
OpenAudioInputImpl(), CloseAudioInputImpl(), AddAudioOutputImpl() are called
only from ControlMessage::Run(), not RunDuringShutdown().

These conditions were first added in
https://hg.mozilla.org/mozilla-central/rev/dcd375e2750d425af210fee36962219a97a334fd#l3.12
but I don't know why.

Comment 8

[Phabricator Automation]

Comment on attachment 9151998 [details]
Bug 1285290 move code to choose the next GraphDriver to CheckDriver() r?padenot

Revision D76803 was moved to bug 1285290. Setting attachment 9151998 [details] to obsolete.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b14e6ad106a5
Bug 1285290 set prefs on two crashtests to allow autoplay r=padenot
https://hg.mozilla.org/integration/autoland/rev/a5931e2c9a13
Bug 1285290 don't add destroyed tracks to graph from Increment/DecrementSuspendCount r=padenot
https://hg.mozilla.org/integration/autoland/rev/c17adfdc55cd
Bug 1285290 move AudioContextOperationControlMessage out of function scope r=padenot
https://hg.mozilla.org/integration/autoland/rev/7bae1eadb123
Bug 1285290 alias move() to std::move() in MediaTrackGraph.cpp and AudioContext.cpp r=padenot
https://hg.mozilla.org/integration/autoland/rev/806573d7d69a
remove some graph-thread LIFECYCLE_RUNNING conditions r=padenot
https://hg.mozilla.org/integration/autoland/rev/a1dd9afbfdf5
Bug 1285290 Document suspend/resume accounting wrt ApplyAudioContextOperation() r=padenot

Comment 10

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/b14e6ad106a5
https://hg.mozilla.org/mozilla-central/rev/a5931e2c9a13
https://hg.mozilla.org/mozilla-central/rev/c17adfdc55cd
https://hg.mozilla.org/mozilla-central/rev/7bae1eadb123
https://hg.mozilla.org/mozilla-central/rev/806573d7d69a
https://hg.mozilla.org/mozilla-central/rev/a1dd9afbfdf5