1641162 - TargetList getAllTargets should accept an array of types as argument

Status: RESOLVED FIXED

(DevTools :: General, task, P3)

Description

[Julian Descottes [:jdescottes]]

See https://phabricator.services.mozilla.com/D65528#inline-444551

getAllTargets only takes a single resource type as argument, so if you want really all targets you need to iterate twice:

    for (const targetType of this.targetList.ALL_TYPES) {
      // XXX: May be expose a getReallyAllTarget() on TargetList?
      for (const target of this.targetList.getAllTargets(targetType)) {
        // do something with the target...
      }
    }

could be replaced with

for (const target of this.targetList.getAllTargets(this.targetList.ALL_TYPES)) {
  // do something with the target...
}

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1641162 - Use an array of types as argument for TargetList::getAllTargets

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d115cc66c9e8
Use an array of types as argument for TargetList::getAllTargets r=nchevobbe

Comment 3

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/d115cc66c9e8