1641199 - Test under Windows are failing

Status: RESOLVED FIXED

(Conduit :: moz-phab, defect, P2)

Description

[Piotr Zalewa [:zalun]]

13 tests are failing.
4 of which are not related to Unicode issues.

All tests should pass on all supported platforms.

Comment 1

[Piotr Zalewa [:zalun]]

Attachment: Bug 1641199 - Reduce the number of failed tests in Windows. r=zeid

Comment 2

[Piotr Zalewa [:zalun]]

There are currently only 4 failing tests with differences in conduit.call arguments

1. tests\test_integration_git.py::test_submit_create
2. tests\test_integration_hg.py::test_submit_create difference in conduit.call arguments
3. tests\test_integration_hg.py::test_submit_create_no_trailing_newline
4. tests\test_integration_hg.py::test_multiple_copy

Comment 3

[:glob ✱]

Attachment: Bug 1641199 - Various fixes for Windows development

• add sha for colorama to allow dev-requirements installation on windows
• bump callee version so we don't break under py3.9
• replace dead frozendict with immutabledict so we don't break under
  py3.9
• normalise slashes in filepaths in mercurial to fix file modes in
  subdirectories
• use unix text files on windows with mercurial when testing
• don't mix line endings in tests
• use venv install black and flake8 executables when testing style
• update README to include Windows instructions, and make the
  instructions more verbose
• add windows testing to circleci

Comment 4

[:glob ✱]

https://github.com/mozilla-conduit/review/commit/a7fe91713fadc98ce149483e22682e773977cd79