1641202 - Decouple Stencil instantiation from FunctionBox/SharedContext

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P2)

Description

[Ted Campbell [:tcampbell]]

While the Parser/BCE generate ScriptStencils for the majority of their result data, we still use the FunctionBox/SharedContext while doing the instantiation of VM scripts. This bug is about tracking the missing info in the ScriptStencil so that it can outlive the frontend LifoAlloc.

At least the following need to be fixed:

• SourceExtent
• FunctionFlags
• FunctionName

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Bug 1641202 - Part 1: Remove non-existent FunctionBox::hasFunctionStencil declaration. r?tcampbell!

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Bug 1641202 - Part 2: Rewind CompilationInfo.{funcData,functions}. r?tcampbell!

Depends on D81147

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: Bug 1641202 - Part 3: Use CompilationInfo.topLevel for top-level function. r?tcampbell!

Depends on D81148

Comment 4

[Tooru Fujisawa [:arai]]

Attachment: Bug 1641202 - Part 4: Merge 2 PerHandlerParser::newFunctionBox into single implementation. r?tcampbell!

Depends on D81149

Comment 5

[Tooru Fujisawa [:arai]]

Attachment: Bug 1641202 - Part 5: Eagerly emplace ScriptStencil.functionIndex. r?tcampbell!

Depends on D81150

Comment 6

[Tooru Fujisawa [:arai]]

Attachment: Bug 1641202 - Part 6: Add some JSFunction-related fields from FunctionBox to ScriptStencil. r?tcampbell!

Also moved FunctionBox::createFunction to CreateFunction in order to
separate the logic from FunctionBox later.

Depends on D81151

Comment 7

[Tooru Fujisawa [:arai]]

Attachment: Bug 1641202 - Part 7: Copy SourceExtent into ScriptStencil. r?tcampbell!

Depends on D81152

Comment 8

[Tooru Fujisawa [:arai]]

Attachment: Bug 1641202 - Part 8: Use ScriptStencil.isAsmJSModule in top level. r?tcampbell!

Depends on D81153

Comment 9

[Tooru Fujisawa [:arai]]

Attachment: Bug 1641202 - Part 9: Copy function atom to ScriptStencil. r?tcampbell!

Depends on D81154

Comment 10

[Tooru Fujisawa [:arai]]

Attachment: Bug 1641202 - Part 10: Use ScriptStencil instead of FunctionBox as much as possible when instantiation. r?tcampbell!

Later patch will replace remaining FunctionBox reference in stencil
instantiation.

Depends on D81155

Comment 11

[Tooru Fujisawa [:arai]]

Attachment: Bug 1641202 - Part 12: Copy more fields from FunctionBox to ScriptStencil. r?tcampbell!

Depends on D81157

Comment 12

[Tooru Fujisawa [:arai]]

Attachment: Bug 1641202 - Part 13: Directly use CompilationInfo.funcData instead of FunctionBox list while instantiation. r?tcampbell!

Depends on D81158

Comment 13

[Tooru Fujisawa [:arai]]

Attachment: Bug 1641202 - Part 14: Remove tracing from FunctionBox. r?tcampbell!

Depends on D81159

Comment 14

[Tooru Fujisawa [:arai]]

Attachment: Bug 1641202 - Part 11: Move top-level function enclosing scope into CompilationInfo, and store ScopeIndex in FunctionBox. r?tcampbell!

Depends on D81157

Comment 15

[Tooru Fujisawa [:arai]]

Attachment: Bug 1641202 - Part 15: Remove SharedContext.immutableFlags and directly modify ScriptStencil.immutableFlags. r?tcampbell!

To check if certain stencil is function or not, without relying on
ScriptStencil.functionIndex, ScriptStencil.immutableFlags should be modified
eagarly, instead of at the end of parsing/compilation.

Depends on D81160

Comment 16

[Tooru Fujisawa [:arai]]

Attachment: Bug 1641202 - Part 14: Remove ScriptStencil.functionIndex. r?tcampbell!

Depends on D81393

Comment 17

[Tooru Fujisawa [:arai]]

there is remaining part in ScopeCreationData, that needs to be replaced by FunctionIndex and individual field data
https://searchfox.org/mozilla-central/rev/5a4aaccb28665807a6fd49cf48367d47fbb5a19a/js/src/frontend/Stencil.h#217

Comment 18

[Tooru Fujisawa [:arai]]

Attachment: Bug 1641202 - Part 15: Copy treatAsRunOnce to lazy function. r?tcampbell!

Depends on D81394

Comment 19

[Tooru Fujisawa [:arai]]

Attachment: Bug 1641202 - Part 16: Use FunctionIndex in FunctionBox. r?tcampbell!

Depends on D82533

Comment 20

[Tooru Fujisawa [:arai]]

Attachment: Bug 1641202 - Part 17: Store FunctionIndex in ScopeCreationData. r?tcampbell!

Depends on D82534

Comment 21

[Tooru Fujisawa [:arai]]

Attachment: Bug 1641202 - Part 18: Add comment for UpdatedFields. r?tcampbell!

Depends on D82535

Comment 22

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9f6064e642af
Part 1: Remove non-existent FunctionBox::hasFunctionStencil declaration. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/083eaaa198a4
Part 2: Rewind CompilationInfo.{funcData,functions}. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/88867904264a
Part 3: Use CompilationInfo.topLevel for top-level function. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/c7a3e1e64779
Part 4: Merge 2 PerHandlerParser::newFunctionBox into single implementation. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/d19842bdc536
Part 5: Eagerly emplace ScriptStencil.functionIndex. r=tcampbell

Comment 23

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/9f6064e642af
https://hg.mozilla.org/mozilla-central/rev/083eaaa198a4
https://hg.mozilla.org/mozilla-central/rev/88867904264a
https://hg.mozilla.org/mozilla-central/rev/c7a3e1e64779
https://hg.mozilla.org/mozilla-central/rev/d19842bdc536

Comment 24

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d0e0b6bea64b
Part 6: Add some JSFunction-related fields from FunctionBox to ScriptStencil. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/5b59137f3bf2
Part 7: Copy SourceExtent into ScriptStencil. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/d486d03edf00
Part 8: Use ScriptStencil.isAsmJSModule in top level. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/89afdcc3e7e5
Part 9: Copy function atom to ScriptStencil. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/db845919143a
Part 10: Use ScriptStencil instead of FunctionBox as much as possible when instantiation. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/388fd0366c21
Part 11: Move top-level function enclosing scope into CompilationInfo, and store ScopeIndex in FunctionBox. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/afd5c026cc19
Part 12: Copy more fields from FunctionBox to ScriptStencil. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/70e75d937da5
Part 13: Directly use CompilationInfo.funcData instead of FunctionBox list while instantiation. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/fae2a26e920a
Part 14: Remove ScriptStencil.functionIndex. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/08f7ecebf503
Part 15: Copy treatAsRunOnce to lazy function. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/5e939bbeea80
Part 16: Use FunctionIndex in FunctionBox. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/f7f6f94b7377
Part 17: Store FunctionIndex in ScopeCreationData. r=tcampbell

Comment 25

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/d0e0b6bea64b
https://hg.mozilla.org/mozilla-central/rev/5b59137f3bf2
https://hg.mozilla.org/mozilla-central/rev/d486d03edf00
https://hg.mozilla.org/mozilla-central/rev/89afdcc3e7e5
https://hg.mozilla.org/mozilla-central/rev/db845919143a
https://hg.mozilla.org/mozilla-central/rev/388fd0366c21
https://hg.mozilla.org/mozilla-central/rev/afd5c026cc19
https://hg.mozilla.org/mozilla-central/rev/70e75d937da5
https://hg.mozilla.org/mozilla-central/rev/fae2a26e920a
https://hg.mozilla.org/mozilla-central/rev/08f7ecebf503
https://hg.mozilla.org/mozilla-central/rev/5e939bbeea80
https://hg.mozilla.org/mozilla-central/rev/f7f6f94b7377