Closed
Bug 1641245
Opened 6 years ago
Closed 6 years ago
Make string comparators non-virtual.
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla78
| Tracking | Status | |
|---|---|---|
| firefox78 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
Details
Attachments
(1 file)
These are hot and we don't have any use case for the extra statefulness that using a class with virtual operator() provides.
|
Assignee | |
Comment 1•6 years ago
|
||
There's no use case for stateful comparators, so they can be just plain
function pointers.
This is used in some hot places like CSS selector matching.
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b4db58c003ae
Make string comparators not virtual. r=froydnj,necko-reviewers,geckoview-reviewers,jgilbert,agi,valentin
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/autoland/rev/c35efe3c43dc
Fix silly windows build bustage.
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/b4db58c003ae
https://hg.mozilla.org/mozilla-central/rev/c35efe3c43dc
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox78:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/b987d3619e0c
Port bug 1641245 - Make string comparators not virtual. rs=bustage-fix
|
||
Updated•5 years ago
|
Component: String → XPCOM
You need to log in
before you can comment on or make changes to this bug.
Description
•