Closed Bug 1641261 Opened 4 months ago Closed 4 months ago

Handle the case when an app provided engine is hidden/removed, and a WebExtension wants to select as default.

Categories

(Firefox :: Search, task, P1)

task
Points:
2

Tracking

()

VERIFIED FIXED
Firefox 78
Iteration:
78.2 - May 18 - May 31
Tracking Status
firefox78 --- verified

People

(Reporter: standard8, Assigned: standard8)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Currently, when an app-provided engine is hidden / removed, and a WebExtension wants to select that one as default, we end up in a strange state:

  • The existing engine remains as default.
  • Preferences says an add-on has set your default.

Ideally, we should probably prompt the user to check that they want to unhide the engine. For the first step, we're going to make it so that in this case nothing happens. A future step (and follow-up bug) will be to add a prompt.

Blocks: 1641811

Filed bug 1641811 for the follow-up.

Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d82a23f070f6
Handle the case when an app provided engine is hidden/removed, and a WebExtension wants to select as default. r=daleharvey

qe-verify:

STR:

  • Hide the DuckDuckGo engine
  • Install DuckDuckGo Privacy Essentials

Without the patch the default engine does not get changed, but preferences will show DDG Privacy Essentials has set the default engine. iirc it also tries to add an additional engine (until restart).

With the patch, the default engine does not get changed, and preferences does not show any add-on as having set the default.

Would be good to run through some of the override tests as well (bug 1635220), as this code path is related to that.

Flags: qe-verify+

I forgot this would affect that test as well. Fixed, and pushing new patch.

Flags: needinfo?(standard8)
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dffde7d17397
Handle the case when an app provided engine is hidden/removed, and a WebExtension wants to select as default. r=daleharvey
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 78

Verified with 78.0b8 on macOS 10.15.5, Windows 10, Ubuntu 18

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.