1641261 - Handle the case when an app provided engine is hidden/removed, and a WebExtension wants to select as default.

Status: VERIFIED FIXED

(Firefox :: Search, task, P1)

Description

[Mark Banner (:standard8)]

Currently, when an app-provided engine is hidden / removed, and a WebExtension wants to select that one as default, we end up in a strange state:

• The existing engine remains as default.
• Preferences says an add-on has set your default.

Ideally, we should probably prompt the user to check that they want to unhide the engine. For the first step, we're going to make it so that in this case nothing happens. A future step (and follow-up bug) will be to add a prompt.

Comment 1

[Mark Banner (:standard8)]

Filed bug 1641811 for the follow-up.

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1641261 - Handle the case when an app provided engine is hidden/removed, and a WebExtension wants to select as default. r?daleharvey!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d82a23f070f6
Handle the case when an app provided engine is hidden/removed, and a WebExtension wants to select as default. r=daleharvey

Comment 4

[Mark Banner (:standard8)]

qe-verify:

STR:

• Hide the DuckDuckGo engine
• Install DuckDuckGo Privacy Essentials

Without the patch the default engine does not get changed, but preferences will show DDG Privacy Essentials has set the default engine. iirc it also tries to add an additional engine (until restart).

With the patch, the default engine does not get changed, and preferences does not show any add-on as having set the default.

Would be good to run through some of the override tests as well (bug 1635220), as this code path is related to that.

Comment 5

[Alexandru Michis [:malexandru]]

Backed out changeset d82a23f070f6 for causing xpcshell failures in test_override_allowlist.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/1e5f15384a6f004ec6345b36090e5b565199b311

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception%2Crunnable&revision=d82a23f070f69cb08a05d48fab49dbd67ebb81aa&searchStr=xpc&selectedTaskRun=W1YlUCscRheG3-DNVPX8fg-0

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=304375565&repo=autoland&lineNumber=3030

Comment 6

[Mark Banner (:standard8)]

I forgot this would affect that test as well. Fixed, and pushing new patch.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dffde7d17397
Handle the case when an app provided engine is hidden/removed, and a WebExtension wants to select as default. r=daleharvey

Comment 8

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/dffde7d17397

Comment 9

[Cristian Fogel [:cfogel]]

Verified with 78.0b8 on macOS 10.15.5, Windows 10, Ubuntu 18