proxy.onRequest ignores windowId / tabId
Categories
(WebExtensions :: Request Handling, defect, P1)
Tracking
(firefox78 fixed)
| Tracking | Status | |
|---|---|---|
| firefox78 | --- | fixed |
People
(Reporter: robwu, Assigned: robwu)
References
(Regressed 1 open bug)
Details
(Keywords: dev-doc-complete)
Attachments
(1 file)
While working on bug 1638007, I noticed that the proxy.onRequest API does not support tabId/windowId despite the code seemingly trying to do so (because the normalizeFilter helper strips windowId/tabId).
|
Assignee | |
Comment 1•9 months ago
|
||
|
||
Updated•9 months ago
|
Pushed by rob@robwu.nl: https://hg.mozilla.org/integration/autoland/rev/435776ca8a2d Support tabId & windowId filtering in proxy.onRequest r=mixedpuppy
|
||
Comment 3•9 months ago
|
||
| bugherder | ||
|
||
Comment 4•9 months ago
|
||
Noting for the record this is already documented at https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/webRequest/RequestFilter
|
|
Assignee | |
Comment 5•9 months ago
|
||
The onRequest event was only added in Firefox 60 - https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/proxy/onRequest
including "support" for windowId / tabId in the filter.
However, until this bug was fixed in Firefox 78, the filter did not work - all requests were shown regardless of the tabId/windowId values in the filter.
|
||
Comment 6•8 months ago
|
||
I've added a note to the BCD table for this: https://wiki.developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/proxy/onRequest#Browser_compatibility
Marking dev-doc-complete, but please let me know if you need anything else here.
Description
•