Closed Bug 1641269 Opened 9 months ago Closed 9 months ago

proxy.onRequest ignores windowId / tabId

Categories

(WebExtensions :: Request Handling, defect, P1)

defect

Tracking

(firefox78 fixed)

RESOLVED FIXED
mozilla78
Tracking Status
firefox78 --- fixed

People

(Reporter: robwu, Assigned: robwu)

References

(Regressed 1 open bug)

Details

(Keywords: dev-doc-complete)

Attachments

(1 file)

While working on bug 1638007, I noticed that the proxy.onRequest API does not support tabId/windowId despite the code seemingly trying to do so (because the normalizeFilter helper strips windowId/tabId).

https://searchfox.org/mozilla-central/rev/bc3600def806859c31b2c7ac06e3d69271052a89/toolkit/components/extensions/ProxyChannelFilter.jsm#258-268,274,351-357

Severity: -- → S2
Priority: -- → P1
Pushed by rob@robwu.nl:
https://hg.mozilla.org/integration/autoland/rev/435776ca8a2d
Support tabId & windowId filtering in proxy.onRequest r=mixedpuppy
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
Regressions: 1642115

The onRequest event was only added in Firefox 60 - https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/proxy/onRequest
including "support" for windowId / tabId in the filter.
However, until this bug was fixed in Firefox 78, the filter did not work - all requests were shown regardless of the tabId/windowId values in the filter.

I've added a note to the BCD table for this: https://wiki.developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/proxy/onRequest#Browser_compatibility

Marking dev-doc-complete, but please let me know if you need anything else here.

You need to log in before you can comment on or make changes to this bug.