1641269 - proxy.onRequest ignores windowId / tabId

Status: RESOLVED FIXED

(WebExtensions :: Request Handling, defect, P1)

Description

[Rob Wu [:robwu]]

While working on bug 1638007, I noticed that the proxy.onRequest API does not support tabId/windowId despite the code seemingly trying to do so (because the normalizeFilter helper strips windowId/tabId).

https://searchfox.org/mozilla-central/rev/bc3600def806859c31b2c7ac06e3d69271052a89/toolkit/components/extensions/ProxyChannelFilter.jsm#258-268,274,351-357

Comment 1

[Rob Wu [:robwu]]

Attachment: Bug 1641269 - Support tabId & windowId filtering in proxy.onRequest

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/435776ca8a2d
Support tabId & windowId filtering in proxy.onRequest r=mixedpuppy

Comment 3

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/435776ca8a2d

Comment 4

[Philipp Kewisch [:Fallen][📱📆]]

Noting for the record this is already documented at https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/webRequest/RequestFilter

Comment 5

[Rob Wu [:robwu]]

The onRequest event was only added in Firefox 60 - https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/proxy/onRequest
including "support" for windowId / tabId in the filter.
However, until this bug was fixed in Firefox 78, the filter did not work - all requests were shown regardless of the tabId/windowId values in the filter.

Comment 6

[Will Bamberg [:wbamberg]]

I've added a note to the BCD table for this: https://wiki.developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/proxy/onRequest#Browser_compatibility

Marking dev-doc-complete, but please let me know if you need anything else here.