1641284 - [wpt-sync] Sync PR 23798 - Fixes input image type fallback content to respect display property.

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 23798 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/23798
Details from upstream follow.

Yu Han <[e-mail]> wrote:

Fixes input image type fallback content to respect display property.

Prior to this CL, image input type will always use a Block layout when
the image src can't be loaded. This prevents web developers from changing
the layout via CSS display property.

This CL fixes the issue by creating a Layout object based on the CSS
computed styles. Web developers can change image's fallback text layout
via CSS display property. If none is passed it, it defaults to
inline-block, which is the default layout of the input image type.

Bug:948066
Change-Id: I907432485472c472608b9d84d36fa2df29412f7c

Reviewed-on: https://chromium-review.googlesource.com/2212963
WPT-Export-Revision: 332ca14ddf0f1bc05ace68628a46420cd84cd46f

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=fdf9a2e4b3bd0119d5e2466e141e401c9ec6e2d3

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1
FAIL: 1

Chrome

FAIL: 1

Safari

FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/html/rendering/replaced-elements/attributes-for-embedded-content-and-images/input-image-inline-alt.html: FAIL [Gecko-android-em-7.0-x86_64-debug-geckoview], PASS [Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt, GitHub] (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2b3d5e91ef77
[wpt PR 23798] - Fixes input image type fallback content to respect display property., a=testonly
https://hg.mozilla.org/integration/autoland/rev/a824c0e02cfd
[wpt PR 23798] - Update wpt metadata, a=testonly

Comment 4

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/2b3d5e91ef77
https://hg.mozilla.org/mozilla-central/rev/a824c0e02cfd