1641352 - Irregexp: GC-free regexp parsing

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P2)

Description

[Iain Ireland [:iain]]

When parsing a regexp containing named captures, irregexp will allocate a FixedArray (which we implement using an ArrayObject) to hold the named capture data. This is undesirable for the SM parser, which only wants to know whether the regexp has valid syntax and should not allocate any GC things.

To fix this, I upstreamed a patch that adds a second entry point for parsing that only checks syntax (and enforces it with the V8 equivalent of an AutoAssertNoGC).

After a re-import, GC-free parse is a piece of cake.

Comment 1

[Iain Ireland [:iain]]

Attachment: Bug 1641352: Re-import Irregexp r=mgaudet

This patch was auto-generated using import-irregexp.py.

Comment 2

[Iain Ireland [:iain]]

Attachment: Bug 1641352: Use VerifyRegExpSyntax in CheckPatternSyntaxImpl r=mgaudet

Depends on D77296

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a5279519ad7c
Re-import Irregexp r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/84ba4c53cb3f
Use VerifyRegExpSyntax in CheckPatternSyntaxImpl r=mgaudet

Comment 4

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/a5279519ad7c
https://hg.mozilla.org/mozilla-central/rev/84ba4c53cb3f