1641389 - Remove image.webp.enabled pref, as it is always on now

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, task)

Description

[Andrew Osmond [:aosmond] (he/him)]

We don't need the image.web.enabled pref anymore, the feature is mature and we've been shipping for a long time.

Comment 1

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1641389 - Remove image.webp.enabled pref, always on by default.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fd4e161666b0
Remove image.webp.enabled pref, always on by default. r=tnikkel

Comment 3

[Razvan Maries]

Backed out for build bustages.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&searchStr=os%2Cx%2Ccross%2Ccompiled%2Cdebug%2Cbuild-macosx64%2Fdebug%2C%28b%29&revision=fd4e161666b0d8f50afd5369823e121e9cde4522&selectedTaskRun=S-6A6zjFQ9KAKjEouJ_OIQ-0

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=304026505&repo=autoland&lineNumber=23601

Backout: https://hg.mozilla.org/integration/autoland/rev/c3bf84087f405d748f74aa12a290d8a0aef8f51f

Comment 4

[Andrew Osmond [:aosmond] (he/him)]

Collision on autoland.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6c865ed1f998
Remove image.webp.enabled pref, always on by default. r=tnikkel

Comment 6

[Razvan Maries]

Backed out for perma failures on test_animation_operators.html.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedTaskRun=fSDrzl4BTqCHJ5QLCo17Bg-0&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=2d65adace3ba6bd22744bcfac4d128c2d08cad14&searchStr=Linux%2C18.04%2Cx64%2Cdebug%2CMochitests%2Ctest-linux1804-64%2Fdebug-mochitest-plain-e10s-15%2CM%2815%29

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=304055954&repo=autoland&lineNumber=5194

Backout: https://hg.mozilla.org/integration/autoland/rev/feab236c0c72f2620647a2ec9b4d633e77e31e5a

Comment 7

[Andrew Osmond [:aosmond] (he/him)]

Huh passed locally for me before I landed. Very annoying.

Comment 8

[Andrew Osmond [:aosmond] (he/him)]

Only the WebP variants fail. That literally makes zero sense given the other WebP tests pass (so it must be enabled).

Comment 9

[Andrew Osmond [:aosmond] (he/him)]

The screenshot provides a clue. "Opening keep.webp, you have chosen to open..." dialog appeared.

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:aosmond, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 11

[Gregory Pappas [:gregp]]

Hi Andrew, I came across this bug while looking for bug 1773039 candidates. Curious why this bug was resolved as WONTFIX without explanation; Would you be alright with it being reopened? Thanks

Comment 12

[Andrew Osmond [:aosmond] (he/him)]

Yes, I think I just didn't understand why the tests were passing and it wasn't worth my time to investigate. I figured it out and will update the patch.

Comment 13

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1641389 - Remove image.webp.enabled pref, always on by default.

Comment 14

[Masatoshi Kimura [:emk]]

Please consider that this flag could be a temporary measure for security vulnerabilities such as CVE-2023-4863.

Comment 15

[Gregory Pappas [:gregp]]

Please consider that this flag could be a temporary measure for security vulnerabilities

I don't see how?

These days, Webp images are ubiquitous (e.g. YouTube thumbnails break when the webp decoder is disabled). Shipping some kind of emergency update/system add-on that flips this pref off would not be practical, I think.

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/106a8fb08a87
Remove image.webp.enabled pref, always on by default. r=necko-reviewers,tnikkel,valentin

Comment 17

[Cosmin Sabou [:CosminS]]

Backed out for causing bc failures on browser_persist_image_accept.js.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=106a8fb08a873ce9a08fcee8ab3442f5fb512d08&test_paths=dom%2Ftests%2Fbrowser%2F&selectedTaskRun=FT9h3XgcRfWDEVFPuZ6nxg.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=429274494&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/1afc936cf70c2bb98fbbcde2b08951a64d64ff44

Comment 18

[Andrew Osmond [:aosmond] (he/him)]

I forgot to update the test after updating the default image request header, try updating the test:
try: https://treeherder.mozilla.org/jobs?repo=try&revision=e157b77a035a08a4eeae809a6bf0d0415c5f1980

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/188f0cf468d3
Remove image.webp.enabled pref, always on by default. r=necko-reviewers,tnikkel,valentin

Comment 20

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/188f0cf468d3