1641442 - Cleanup CompilationInfo::instantiateStencils and friends

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P2)

Description

[Ted Campbell [:tcampbell]]

Miscellaneous cleanup for stencil instantiation to close the gap between lazy and non-lazy BaseScript creation.

Comment 1

[Ted Campbell [:tcampbell]]

Attachment: Bug 1641442 - Use ScriptStencil for lazy ImmutableFlags. r?mgaudet

Compute the ImmutableFlags at the same time as the rest of the LazyScript
GC-things list and store into the ScriptStencil. This is more consistent with
how non-lazy BaseScripts are created.

Depends on D77189

Comment 2

[Ted Campbell [:tcampbell]]

Attachment: Bug 1641442 - Instantiate lazy BaseScripts in same way as non-lazy. r?mgaudet

Defer the lazy BaseScript instantiation to when the rest of the Stencils are
turned into BaseScripts. We also defer the enclosing-lazy-script link updates
until the same time when we call FunctionBox::finish.

Depends on D77192

Comment 3

[Ted Campbell [:tcampbell]]

Attachment: Bug 1641442 - Add CompilationInfo::InstantiateFunctions. r?mgaudet

Rename PublishDeferredFunctions to InstantiateFunctions and inline it's
helper method. Now that trace-list order does not matter we can remove the
asserts and comments around this. The tests pass even if we reverse the
traversal order.

Depends on D77193

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/41b9c39d8aa4
Use ScriptStencil for lazy ImmutableFlags. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/ddd2c41b1f5e
Instantiate lazy BaseScripts in same way as non-lazy. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/5f94c1b0d796
Add CompilationInfo::InstantiateFunctions. r=mgaudet

Comment 5

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/41b9c39d8aa4
https://hg.mozilla.org/mozilla-central/rev/ddd2c41b1f5e
https://hg.mozilla.org/mozilla-central/rev/5f94c1b0d796