1641466 - Some CacheIR cleanups for lazy functions

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, task, P3)

Description

[Jan de Mooij [:jandem]]

Now that all scripted functions have a JIT entry, we can simplify some CacheIR code for getters/setters/calls. We no longer have to treat lazy functions as temporarily-unoptimizable.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Bug 1641466 part 1 - Clean up some CacheIR code now that all scripted functions have a JIT entry. r?tcampbell!

The interpreter trampoline now works for all lazy functions so instead of
temporarily-deoptimizing we should just attach the stub.

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Bug 1641466 part 2 - Add hasJitEntry and isNativeWithoutJitEntry to FunctionFlags. r?tcampbell!

Depends on D77213

Comment 3

[Jan de Mooij [:jandem]]

Attachment: Bug 1641466 part 3 - Stop using isBuiltinNative in IC code. r?tcampbell!

Use isNative or isNativeWithoutJitEntry instead. isBuiltinNative is still used
to implement hasJitInfo.

Depends on D77405

Comment 4

[Jan de Mooij [:jandem]]

Attachment: Bug 1641466 part 4 - Remove isNativeWithJitEntry. r?tcampbell!

We can use hasJitEntry and isNativeWithoutJitEntry instead. Also removes
isNative/isInterpreted from WrappedFunction.

Depends on D77406

Comment 5

[Jan de Mooij [:jandem]]

Attachment: Bug 1641466 part 5 - Rename GuardFunctionIsNative op to GuardFunctionHasNoJitEntry. r?tcampbell!

This better reflects what the code is doing.

Depends on D77606

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d6a55510a282
part 1 - Clean up some CacheIR code now that all scripted functions have a JIT entry. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/8ce8550b83b2
part 2 - Add hasJitEntry and isNativeWithoutJitEntry to FunctionFlags. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/8390490461f8
part 3 - Stop using isBuiltinNative in IC code. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/e0f00f7ef2ac
part 4 - Remove isNativeWithJitEntry. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/34e587606318
part 5 - Rename GuardFunctionIsNative op to GuardFunctionHasNoJitEntry. r=tcampbell

Comment 7

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/d6a55510a282
https://hg.mozilla.org/mozilla-central/rev/8ce8550b83b2
https://hg.mozilla.org/mozilla-central/rev/8390490461f8
https://hg.mozilla.org/mozilla-central/rev/e0f00f7ef2ac
https://hg.mozilla.org/mozilla-central/rev/34e587606318