1641490 - TargetList::watchTargets should wait for onAvailable to be called on service worker targets

Status: RESOLVED FIXED

(DevTools :: General, task)

Description

[Julian Descottes [:jdescottes]]

We are not waiting correctly for service worker targets to be processed in TargetList::watchTargets

      this._legacyProcessesWatcher = new LegacyProcessesWatcher(
        this.targetList,
        targetFront => {
          // Service workers only live in content processes.
          if (!targetFront.isParentProcess) {
            this._onProcessAvailable({ targetFront });
          }
        },
        targetFront => {
          if (!targetFront.isParentProcess) {
            this._onProcessDestroyed({ targetFront });
          }
        }
      );
      await this._legacyProcessesWatcher.listen();

https://searchfox.org/mozilla-central/rev/bc3600def806859c31b2c7ac06e3d69271052a89/devtools/shared/resources/legacy-target-watchers/legacy-workers-watcher.js#139

In the snippet above we should await on this._onProcessAvailable({ targetFront });.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1641490 - TargetList::watchTargets should wait for onAvailable to be called on service worker targets

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fb5af8498d9f
TargetList::watchTargets should wait for onAvailable to be called on service worker targets r=jlast

Comment 3

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/fb5af8498d9f