1641512 - Improve GetUsageForOrigin* functions

Status: RESOLVED FIXED

(Core :: Storage: Quota Manager, task)

Description

[Simon Giesecke [:sg] [he/him]]

As a follow-up to the discussion in https://phabricator.services.mozilla.com/D77073#inline-446669, it should be checked whether the signature or the name of the GetUsageForOrigin* functions should be changed to either make it clearer that aUsageInfo is an input/output parameter or it should be made a return value instead. If functions remains that have it as an output parameter, it should by convention be made the last parameter.

Comment 1

[Simon Giesecke [:sg] [he/him]]

At the moment, it actually is an input/output parameter when called from here: https://searchfox.org/mozilla-central/rev/bc3600def806859c31b2c7ac06e3d69271052a89/dom/quota/ActorsParent.cpp#9452

But it still is an option to change it to a return value, as the caller could do the aggregation without (significant) overhead due to the simple structure of UsageInfo.

Comment 2

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1641512 - Remove unused UsageInfo::DatabaseUsage function. r=#dom-workers-and-storage

Comment 3

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1641512 - Remove unused include directive. r=#dom-workers-and-storage

Depends on D77446

Comment 4

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1641512 - Simplify return type of FileUsage. r=#dom-workers-and-storage

Depends on D77447

Comment 5

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1641512 - Introduce Usage type with operator+/+=. r=#dom-workers-and-storage

Depends on D77448

Comment 6

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1641512 - Rename AppendTo*Usage methods to Increment*Usage. r=#dom-workers-and-storage

Depends on D77449

Comment 7

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1641512 - Replace Append method by operator+=. r=#dom-workers-and-storage

Depends on D77450

Comment 8

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1641512 - Use Result<UsageInfo, nsresult> as return type of GetUsageForOrigin. r=#dom-workers-and-storage

Depends on D77451

Comment 9

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1641512 - Use Result<UsageInfo, nsresult> as return type of InitOrigin and add separate InitOriginWithoutTracking. r=#dom-workers-and-storage

Depends on D77452

Comment 10

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1641512 - Use Result<UsageInfo, nsresult> as return type of GetUsageForOriginInternal. r=#dom-workers-and-storage

Depends on D77453

Comment 11

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1641512 - Use distinct types for file and database usage. r=#dom-workers-and-storage

Depends on D77454

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6d874119c61a
Remove unused UsageInfo::DatabaseUsage function. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/658679696de7
Remove unused include directive. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/8ffee7c15658
Introduce Usage type with operator+/+=. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/4353acf31e97
Rename AppendTo*Usage methods to Increment*Usage. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/44c20d8025ec
Replace Append method by operator+=. r=dom-workers-and-storage-reviewers,janv

Comment 13

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/6d874119c61a
https://hg.mozilla.org/mozilla-central/rev/658679696de7
https://hg.mozilla.org/mozilla-central/rev/8ffee7c15658
https://hg.mozilla.org/mozilla-central/rev/4353acf31e97
https://hg.mozilla.org/mozilla-central/rev/44c20d8025ec

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/12914ebfe67b
Use Result<UsageInfo, nsresult> as return type of GetUsageForOrigin. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/ead91a5bb878
Use Result<UsageInfo, nsresult> as return type of InitOrigin and add separate InitOriginWithoutTracking. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/cb9be96d5643
Use Result<UsageInfo, nsresult> as return type of GetUsageForOriginInternal. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/79252915f36f
Use distinct types for file and database usage. r=dom-workers-and-storage-reviewers,janv

Comment 15

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/12914ebfe67b
https://hg.mozilla.org/mozilla-central/rev/ead91a5bb878
https://hg.mozilla.org/mozilla-central/rev/cb9be96d5643
https://hg.mozilla.org/mozilla-central/rev/79252915f36f