1641517 - FinalizationRegistry cleanupSome method should not be present in the browser

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P2)

Description

[Jon Coppeard (:jonco)]

According to the description of HTML integration for weak refs, this method should be omitted in the browser:

https://github.com/whatwg/html/pull/4571

Discussion is still underway on whether this should be exposed to workers.

Comment 1

[Jon Coppeard (:jonco)]

Attachment: Bug 1641517 - Don't expose FinalizationRegistry.prototype.cleanupSome in the browser r?sfink

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7671b59fd5f3
Don't expose FinalizationRegistry.prototype.cleanupSome in the browser r=mccr8

Comment 3

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/7671b59fd5f3

Comment 4

[Jon Coppeard (:jonco)]

This method is still visible by default.

Comment 5

[Jon Coppeard (:jonco)]

Attachment: Bug 1641517 - Fix logic in ShouldIgnorePropertyDefinition to really ignore cleanupSome if it's not enabled r?sfink

Disabling toSource also disabled checking for whether to ignore cleanupSome.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f0b43814725e
Fix logic in ShouldIgnorePropertyDefinition to really ignore cleanupSome if it's not enabled r=sfink

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/f0b43814725e