1641551 - Node/AccessibleFront should check contenttoolbox.fission pref for the remoteFrame getter

Status: RESOLVED FIXED

(DevTools :: Inspector, task, P3)

Description

[Julian Descottes [:jdescottes]]

Both the accessible and node front provide a remoteFrame getter in order to know if the node/accessible corresponds to a remote frame. This is used to gate some fission-only behavior. However, if we are in a content toolbox and devtools.contenttoolbox.fission is false, we will not really be able to fetch information about the remote frames.

We should probably update the getters to check this preference if we are on a content toolbox.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1641551 - Introduce a supportsFission method on target-mixin

Not completely convinced about the approach, but maybe it can get the ball rolling

Comment 2

[Chris Peterson [:cpeterson]]

Tracking DevTools Fission bugs for Fission Nightly milestone (M6c).

Comment 3

[Chris Peterson [:cpeterson]]

Adding dt-fission whiteboard tag to DevTools bugs that mention Fission or block Fission meta bugs but don't already have a dt-fission whiteboard tag.

Comment 4

[Chris Peterson [:cpeterson]]

Moving dt-fission bugs to Fission MVP.

Comment 5

[Neha Kochar [:neha]]

Bulk change of all bugs with whiteboard tag of dt-fission to Fission MVP milestone.

Comment 6

[Chris Peterson [:cpeterson]]

Moving old "dt-fission" bugs to "dt-fission-future" because they don't block Fission MVP.

Comment 7

[Julian Descottes [:jdescottes]]

As mentioned in our fission chat, I think this should re-prioritized to avoid issues on Beta with the inspector.
There are 3 spots to update:

• https://searchfox.org/mozilla-central/rev/da5d08750e504f3710f7ea051327d9c311c39902/devtools/client/fronts/node.js#284
• https://searchfox.org/mozilla-central/rev/da5d08750e504f3710f7ea051327d9c311c39902/devtools/client/fronts/accessibility.js#47
• https://searchfox.org/mozilla-central/rev/da5d08750e504f3710f7ea051327d9c311c39902/devtools/client/fronts/accessibility.js#314

An easy way to check this would be to also get targetFront.isParentProcess and only check the preference for parent process targets.
That being said, a better fix might be to migrate all the logic relying on remoteFrame getters to commands, where we could check the descriptor rather than a target. But this is not a trivial change.

Comment 8

[Julian Descottes [:jdescottes]]

Attachment: Bug 1641551 - [devtools] Only check browsertoolbox preference for parentProcess targets

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1e91e051cc17
[devtools] Only check browsertoolbox preference for parentProcess targets r=ochameau,bomsy

Comment 10

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/1e91e051cc17