1641616 - Move PopupNotifications.jsm to a component other than "Password Manager"

Status: RESOLVED FIXED

(Toolkit Graveyard :: Notifications and Alerts, task, P3)

Description

[Rob Wu [:robwu]]

PopupNotifications.jsm is currently attributed to the "Password Manager" component. That doesn't look right, I think that It should be elsewhere, e.g. in "General", as the module is also used for UI features that have nothing to do with the password manager.

https://searchfox.org/mozilla-central/rev/9aa7bebfd169bc2ead00ef596498a406e56bbb85/toolkit/modules/moz.build#111-112

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[Ethan Tseng [:ethan]]

Attachment: Bug 1641616 - Move PopupNotifications.jsm to a component other than Password Manager. r=MattN

Comment 3

[Ethan Tseng [:ethan]]

I assume it's not necessary to run Try server tests for this patch. Correct me if I am wrong.

Comment 4

[Matthew N. [:MattN]]

Correct. You can manually test with ./mach file-info bugzilla-component toolkit/modules/PopupNotifications.jsm if you want.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cd6010cff999
Move PopupNotifications.jsm to a component other than Password Manager. r=MattN

Comment 6

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9580ad315bb8
Backed out changeset cd6010cff999 for causing failures at browser_createLogin.js CLOSED TREE

Comment 7

[Atila Butkovits]

Backed out for causing failures at browser_createLogin.

Backout link: https://hg.mozilla.org/integration/autoland/rev/9580ad315bb8ff113ce6678e1af7a1f27ce897e1

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedTaskRun=DhPTm_PqRXGaCBB1tSH4XQ-0&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&revision=3b5928fd85e56855d31055aa8b0797b22f3c8499&failure_classification_id=2

Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=305271067&repo=autoland&lineNumber=2565

Comment 8

[Ethan Tseng [:ethan]]

(In reply to Atila Butkovits from comment #7)

Backed out for causing failures at browser_createLogin.

Sorry, I didn't expect this would happen. I'll fix it soon.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/91a3672a71b4
Move PopupNotifications.jsm to a component other than Password Manager. r=MattN

Comment 10

[Atila Butkovits]

Sorry for the backout. It was a mistake. I relanded your push
https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedTaskRun=Ynps26wOSoaUia_B6yOgCA-0&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&searchStr=windows%2C10%2Cx64%2Cwebrender%2Cshippable%2Copt%2Cmochitests%2Ctest-windows10-64-shippable-qr%2Fopt-mochitest-browser-chrome-e10s-2%2Cm%28bc2%29&tochange=297d2efe3bb859ac149faa038910131047489b15&fromchange=cd6010cff99952a82197e01d2038947ceb279805

Comment 11

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/91a3672a71b4

Comment 12

[Ethan Tseng [:ethan]]

(In reply to Atila Butkovits from comment #10)

Sorry for the backout. It was a mistake. I relanded your push

Thank you, Atlia!