1641632 - Deal with formatting of js.msg

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Matthew Gaudet (he/him) [:mgaudet]]

Today if I save js.msg with my clang-formatter enabled, the whole thing gets reformatted.

We have two choices:

• checkin //clang-format {off,on} comments
• Reformat the file. This means adding line breaks and eliminating columns.

Do we have a preference? I'll attach a patch for the first option, but am open to the second.

Comment 1

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1641632 - Disable clang-formatting of js.msg r?jorendorff DONTBUILD

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a571d66af5b7
Disable clang-formatting of js.msg r=jorendorff DONTBUILD

Comment 3

[Bogdan Tara[:bogdan_tara | bogdant]]

Backed out changeset a571d66af5b7 (bug 1641632) for bustages complaining about WeakRefObject.cpp.

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=build&fromchange=ab2b6a85208a7993b62259158209610b5619c3ef&tochange=a19ea10c4e869e318a7940376eb90864de59cc9f&selectedTaskRun=VeRixI0SQNu_gM5j96MAvg-0

Backout link: https://hg.mozilla.org/integration/autoland/rev/a19ea10c4e869e318a7940376eb90864de59cc9f

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=305846394&repo=autoland&lineNumber=33088

[task 2020-06-10T19:54:59.451Z] 19:54:59     INFO -  make[4]: Entering directory '/builds/worker/workspace/obj-build/js/src'
[task 2020-06-10T19:54:59.454Z] 19:54:59     INFO -  /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/clang++ -std=gnu++17 -o Unified_cpp_js_src3.o -c  -I/builds/worker/workspace/obj-build/dist/system_wrappers -include /builds/worker/checkouts/gecko/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -ftrivial-auto-var-init=pattern -DDEBUG=1 -DWASM_SUPPORTS_HUGE_MEMORY -DJS_CACHEIR_SPEW -DJS_STRUCTURED_SPEW -DJS_HAS_CTYPES -DFFI_BUILDING -DEXPORT_JS_API -DMOZ_HAS_MOZGLUE -I/builds/worker/checkouts/gecko/js/src -I/builds/worker/workspace/obj-build/js/src -I/builds/worker/workspace/obj-build/js/src/ctypes/libffi/include -I/builds/worker/checkouts/gecko/js/src/ctypes/libffi/src/x86 -I/builds/worker/workspace/obj-build/dist/include -I/builds/worker/workspace/obj-build/dist/include/nspr -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/obj-build/js/src/js-confdefs.h -Qunused-arguments -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wempty-init-stmt -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Wunused-function -Wunused-variable -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wtautological-unsigned-enum-zero-compare -Wtautological-unsigned-zero-compare -Wno-error=tautological-type-limit-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wno-error=return-std-move -Wno-error=atomic-alignment -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-noexcept-type -Wno-unknown-warning-option -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -fno-aligned-new -fcrash-diagnostics-dir=/builds/worker/artifacts -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -Xclang -load -Xclang /builds/worker/workspace/obj-build/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O3 -fno-omit-frame-pointer -funwind-tables -Werror -fno-strict-aliasing -Werror=format -Wno-shadow -fexperimental-new-pass-manager  -MD -MP -MF .deps/Unified_cpp_js_src3.o.pp   Unified_cpp_js_src3.cpp
[task 2020-06-10T19:54:59.454Z] 19:54:59     INFO -  In file included from Unified_cpp_js_src3.cpp:29:
[task 2020-06-10T19:54:59.455Z] 19:54:59    ERROR -  /builds/worker/checkouts/gecko/js/src/builtin/WeakRefObject.cpp:99:31: error: use of undeclared identifier 'JSMSG_BAD_WEAKREF_TARGET'; did you mean 'JSMSG_BAD_DESTRUCT_TARGET'?
[task 2020-06-10T19:54:59.455Z] 19:54:59     INFO -                                JSMSG_BAD_WEAKREF_TARGET);
[task 2020-06-10T19:54:59.456Z] 19:54:59     INFO -                                ^~~~~~~~~~~~~~~~~~~~~~~~
[task 2020-06-10T19:54:59.456Z] 19:54:59     INFO -                                JSMSG_BAD_DESTRUCT_TARGET
[task 2020-06-10T19:54:59.456Z] 19:54:59     INFO -  /builds/worker/checkouts/gecko/js/src/js.msg:207:9: note: 'JSMSG_BAD_DESTRUCT_TARGET' declared here
[task 2020-06-10T19:54:59.457Z] 19:54:59     INFO -  MSG_DEF(JSMSG_BAD_DESTRUCT_TARGET,     0, JSEXN_SYNTAXERR, "invalid destructuring target")
[task 2020-06-10T19:54:59.457Z] 19:54:59     INFO -          ^
[task 2020-06-10T19:54:59.458Z] 19:54:59     INFO -  1 error generated.
[task 2020-06-10T19:54:59.458Z] 19:54:59     INFO -  /builds/worker/checkouts/gecko/config/rules.mk:746: recipe for target 'Unified_cpp_js_src3.o' failed
[task 2020-06-10T19:54:59.459Z] 19:54:59    ERROR -  make[4]: *** [Unified_cpp_js_src3.o] Error 1
[task 2020-06-10T19:54:59.459Z] 19:54:59     INFO -  make[4]: Leaving directory '/builds/worker/workspace/obj-build/js/src'
[task 2020-06-10T19:54:59.460Z] 19:54:59     INFO -  make[4]: *** Waiting for unfinished jobs....

Comment 4

[Matthew Gaudet (he/him) [:mgaudet]]

Opened Bug 1644874 to see if we can get some bumpers put up to prevent this.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6dad11f28600
Disable clang-formatting of js.msg r=jorendorff DONTBUILD

Comment 6

[mac198442]

Really how did a patch missing such an obvious line break get reviewed and landed?

Comment 7

[Bogdan Tara[:bogdan_tara | bogdant]]

Backed out changeset 6dad11f28600 (bug 1641632) by mgaudet's request.

Backout link: https://hg.mozilla.org/integration/autoland/rev/a9632aadfd85380d86fbdeb5113d3035d5032308

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/942be1745042
Disable clang-formatting of js.msg r=jorendorff DONTBUILD

Comment 9

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/942be1745042