1641671 - Emojis with a scaling transform applied render at wrong size while pinch-zooming

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Connor Brewster [:cbrewster]]

Attachment: emoji-scaled-test-case.html

If a scale transform is applied to text with an emoji, the emoji changes size while pinch-zooming.

This looks similar to bug 1640120, but the fix there might not take into account transforms on the text itself?

Comment 1

[Connor Brewster [:cbrewster]]

Attachment: emoji-scaling-bug.mov

Comment 2

[Jamie Nicol [:jnicol]]

For me the 'A' goes very blurry when zooming too, which could well be related

Comment 3

[Connor Brewster [:cbrewster]]

I've noticed scaled text get blurry while pinch-zooming as well, although it only happens intermittently, which is odd. I haven't figured out a good way to always reproduce it yet.

Comment 4

[Lee Salzman [:lsalzman]]

Attachment: Bug 1641671 - represent font size as f32 to avoid quantization issues. r?aosmond

Comment 5

[Lee Salzman [:lsalzman]]

Attachment: Bug 1641671 - fold device scale back into font size since it is no longer quantized. r?aosmond

Depends on D77367

Comment 6

[Lee Salzman [:lsalzman]]

Attachment: Bug 1641671 - move FontInstance bools into FontInstanceFlags. r?aosmond

Depends on D77368

Comment 7

[Andrew Osmond [:aosmond] (he/him)]

Loving the patches, quantization is one the deadly sins of snapping!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5955d6350316
represent font size as f32 to avoid quantization issues. r=aosmond
https://hg.mozilla.org/integration/autoland/rev/d1cf46887bec
fold device scale back into font size since it is no longer quantized. r=aosmond
https://hg.mozilla.org/integration/autoland/rev/0b168eb24806
move FontInstance bools into FontInstanceFlags. r=aosmond

Comment 9

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/5955d6350316
https://hg.mozilla.org/mozilla-central/rev/d1cf46887bec
https://hg.mozilla.org/mozilla-central/rev/0b168eb24806