1641789 - Make some CacheIR code work with numbers instead of just doubles

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, task, P2)

Description

[Jan de Mooij [:jandem]]

Once we see a double it's better to add a stub that still works for int32 too. That's what we do for most operations and this works well with Warp, but the stub for binary bitwise operations only accepted doubles, causing perf issues for Warp.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Bug 1641789 part 1 - Change TruncateDoubleToUInt32 input from ValId to NumberId. r?evilpie!

Use GuardIsNumber for binary bitwise operations so that the stub works for int32
too. The IC code may be slightly less efficient now for int32 values because they
are converted to double but this is consistent with other code and helps Warp a lot.

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Bug 1641789 part 2 - Change LoadDoubleTruthyResult input from ValId to NumberId. r?evilpie!

Depends on D77420

Comment 3

[Jan de Mooij [:jandem]]

Attachment: Bug 1641789 part 3 - Rename GuardType to GuardNonDoubleType and remove support for doubles. r?evilpie!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/102cb2082b8a
part 1 - Change TruncateDoubleToUInt32 input from ValId to NumberId. r=evilpie
https://hg.mozilla.org/integration/autoland/rev/b1cdd829acc9
part 2 - Change LoadDoubleTruthyResult input from ValId to NumberId. r=evilpie
https://hg.mozilla.org/integration/autoland/rev/61f9f26e554c
part 3 - Rename GuardType to GuardNonDoubleType and remove support for doubles. r=evilpie

Comment 5

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/102cb2082b8a
https://hg.mozilla.org/mozilla-central/rev/b1cdd829acc9
https://hg.mozilla.org/mozilla-central/rev/61f9f26e554c