1641826 - PartiallySeekableInputStream should call the callback immediately upon receiving AsyncWait if stream is closed

Status: RESOLVED FIXED

(Core :: Networking, defect, P2)

Description

[Subhamoy [:ssengupta][he/him]]

Currently multiple implementations of nsIAsyncInputStream return an error code (e.g., NS_BASE_STREAM_CLOSED) and do not call the callback if AsyncWait is called and the stream is already closed, which is not expected behaviour. These implementations should be updated to call the callback immediately in such a situation instead of returning an error.

Comment 1

[Subhamoy [:ssengupta][he/him]]

Attachment: Bug 1641826 - P1 - PartiallySeekableInputStream does not return error and executes callback on AsyncWait/AsyncLengthWait if stream is closed r=baku

Comment 2

[Subhamoy [:ssengupta][he/him]]

Attachment: Bug 1641826 - P2 - GTest cases added for PartiallySeekableInputStream to test AsyncWait/AsyncLengthWait behaviour when stream closed r=baku

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/84380136974d
P1 - PartiallySeekableInputStream does not return error and executes callback on AsyncWait/AsyncLengthWait if stream is closed r=baku,necko-reviewers,mayhemer
https://hg.mozilla.org/integration/autoland/rev/282fdf095683
P2 - GTest cases added for PartiallySeekableInputStream to test AsyncWait/AsyncLengthWait behaviour when stream closed r=baku,necko-reviewers,mayhemer

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/84380136974d
https://hg.mozilla.org/mozilla-central/rev/282fdf095683