1641942 - Form history suggestion dropdown now appears upon focus of username fields without saved logins

Status: NEW

(Toolkit :: Password Manager, defect, P2)

Description

[kabutotx]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:76.0) Gecko/20100101 Firefox/76.0

Steps to reproduce:

Starting around v74 or so, Firefox started to pop up the input field selection on page load for sites that do a focus to the first input field. It didn't used to do this unless you did onClick().

Expected results:

Make drop down only for onClick() events or after typing letter(s).

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[Cameron McCormack (:heycam)]

I am not seeing this behavior. Do you have a URL for a page that exhibits this problem?

Comment 3

[kabutotx]

https://github.com/login
It automatically drops down with my email address.
I think it is the autofocus. My company website had old javascript code to autofocus the login input box and it still did the same thing. I changed it to autofocus just to test but it still did it. Of course a single click toggles it on and off. Typing will limit the drop down. Just annoys me that it always pops up loading my admin site login. :)

Comment 4

[Cameron McCormack (:heycam)]

OK, mozregression tells me this changed as a result of bug 1388674. Matt, can you confirm whether showing the autocomplete popup when the field is focused but without any user interaction is the intended behavior here?

Comment 5

[Matthew N. [:MattN]]

We didn't change the behaviour for <input> in general but I thought we already had this behaviour for login fields before then.

Are both of you referring to when there is a login saved (key icon beside the username) or just regular form history?

Comment 6

[kabutotx]

Regular from history. I have no saved logins.

Comment 7

[Matthew N. [:MattN]]

OK, thanks. This wasn't intentional then.

One of the gFormFillService.showPopup(); calls in LoginManagerChild.jsm must now be getting hit.

Does the problem happen outside of login forms? I guess not?

Comment 8

[Cameron McCormack (:heycam)]

(In reply to Matthew N. [:MattN] from comment #7)

Does the problem happen outside of login forms? I guess not?

Seems not. Can reproduce with https://mcc.id.au/temp/login-form.html but not https://mcc.id.au/temp/non-login-form.html.

Comment 9

[Matthew N. [:MattN]]

This is in our P2 list but it's unlikely I will personally fix this.