1641966 - create process for patches that add tasks to the taskgraph

Status: RESOLVED DUPLICATE of bug 1635465

(Testing :: General, enhancement)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

In reviewing a patch today I had a lot of questions- it was great to see some forethought to restrict to a single config, but it looked to be duplicating dozens of jobs.

:ahal and I chatted for a bit about this and thought a more formal process would be good.

Some thoughts would flow like so:

1. developer submits patch, reviewbot runs taskgraph diff job and outputs net new jobs + estimated load
2. if any new jobs: require developer to include <details> about the new jobs
3. if count new jobs:

   5: require review from infra team
   10: addition required review from manager
   50: requires VP signature

for <details> I imagine:

• business reason for this
• justification for platforms/configs chosen
• risk of not running this
• when will this feature ship
• what branches should this run on
• owner (person(s), team)
• expiration of new jobs
• try run with proof of minimal intermittent failures
• acknowledgement that you have selected the appropriate tier
  ** this means we need clear definitions of tiers and everything follows those rules

The more this can be automated (review bot job with failures for new jobs, bugzilla form with <details>, notifications to infra team for new tasks) the better we can make this process successful