1642058 - Add expiration date in card list view under Preferences

Status: VERIFIED FIXED

(Toolkit :: Form Autofill, enhancement, P1)

Description

[chsiang]

Card list view should be easier for users to recognize their cards and be consistent with the cc autofill dropdown menu.

Comment 1

[Matthew N. [:MattN]]

This should be as straightforward as changing getLabel(…): https://searchfox.org/mozilla-central/rev/d9d492eda787a6eda66016e6f8398ee759f7bc25/browser/extensions/formautofill/content/manageDialog.js#407-419

Comment 2

[Adam Roach [:abr]]

Attachment: Bug 1642058: Add expiration date in card list view under Preferences r?zbraniecki,MattN

Comment 3

[Adam Roach [:abr]]

Comment from Holly: we need to format the expiration date with some explanatory text, e.g., "**** 3333, John Smith, Expires on MM/YYYY". I will be revising the patch to accommodate.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/85183f00ced0
Add expiration date in card list view under Preferences r=zbraniecki,fluent-reviewers,MattN,flod

Comment 5

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2ac608edaf8f
Backed out changeset 85183f00ced0 for causing failure at browser_manageCreditCardsDialog.js. CLOSED TREE

Comment 6

[Atila Butkovits]

Backed out for causing failure at browser_manageCreditCardsDialog.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/2ac608edaf8f5834658e2f82a9ebef3fbd615cf9

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=85183f00ced0e0592cb8f783c39a5a1da8369b4d&selectedTaskRun=Nt6D5FQFREeL85ACP2D-_A-0

Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=305264931&repo=autoland&lineNumber=32041

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/525d4561fa39
Add expiration date in card list view under Preferences r=zbraniecki,fluent-reviewers,MattN,flod

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/525d4561fa39

Comment 9

[Alin Ilea, Desktop Test Engineering]

Verified - Fixed in latest Nightly 79.0a1 (build id: 20200615214838) using Windows 10 and Ubuntu 18.04.

Comment 10

[Alin Ilea, Desktop Test Engineering]

Attachment: Credit Card expire date.png