1642146 - ./nss/lib/freebl/deprecated/seed.c:531: undefined reference to `PORT_ZAlloc_stub'

Status: RESOLVED FIXED

(NSS :: Build, defect, P1)

Description

[Mike Hommey [:glandium]]

3.53 fails to build (with the make build system) with:

/usr/bin/ld: OBJS/Linux_SINGLE_SHLIB/deprecated/seed.o: in function `SEED_AllocateContext':
./nss/lib/freebl/deprecated/seed.c:531: undefined reference to `PORT_ZAlloc_stub'
/usr/bin/ld: OBJS/Linux_SINGLE_SHLIB/deprecated/seed.o: in function `SEED_InitContext':
./nss/lib/freebl/deprecated/seed.c:559: undefined reference to `PORT_SetError_stub'
/usr/bin/ld: OBJS/Linux_SINGLE_SHLIB/deprecated/seed.o: in function `SEED_CreateContext':
./nss/lib/freebl/deprecated/seed.c:570: undefined reference to `PORT_ZAlloc_stub'
/usr/bin/ld: ./nss/lib/freebl/deprecated/seed.c:575: undefined reference to `PORT_ZFree_stub'
/usr/bin/ld: OBJS/Linux_SINGLE_SHLIB/deprecated/seed.o: in function `SEED_DestroyContext':
./nss/lib/freebl/deprecated/seed.c:589: undefined reference to `PORT_Free_stub'
/usr/bin/ld: OBJS/Linux_SINGLE_SHLIB/deprecated/seed.o: in function `SEED_Encrypt':
./nss/lib/freebl/deprecated/seed.c:626: undefined reference to `PORT_SetError_stub'
/usr/bin/ld: OBJS/Linux_SINGLE_SHLIB/deprecated/seed.o: in function `SEED_Decrypt':
./nss/lib/freebl/deprecated/seed.c:666: undefined reference to `PORT_SetError_stub'
collect2: error: ld returned 1 exit status

Comment 1

[Mike Hommey [:glandium]]

Bug 1622033 moved seed.c from freeblpriv3 to freebl3, this is why linkage fails. In the gyp backend, it's still in freeblpriv3.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1642146 - Move seed.o back into freeblpriv3.

Comment 3

[Benjamin Beurdouche [:beurdouche]]

Oh right, Thanks for the patch @Mike!
The ‘beurdouche’ account on Phabricator can’t review the patch.
Could you please change the reviewer to ‘bbeurdouche’ please?

Comment 4

[Kevin Jacobs [:kjacobs]]

https://hg.mozilla.org/projects/nss/rev/f46fca8ced7fca6aa6de60e3170b2a3b6b2df565