1642149 - Fix require-corp.https.html and require-corp-sw.https.html

Status: RESOLVED FIXED

(Core :: DOM: Networking, defect, P2)

Description

[Eden Chuang[:edenchuang]]

Fix the web-platform-test
html/cross-origin-embedder-policy/require-corp.https.html
html/cross-origin-embedder-policy/require-corp-sw.https.html

Comment 1

[Eden Chuang[:edenchuang]]

Attachment: Bug 1642149 - P1 Fix the web-platform-test html/cross-origin-embedder-policy/require-corp.https.html

Comment 2

[Eden Chuang[:edenchuang]]

Attachment: Bug 1642149 - P2 ImportScript() in workers must respect the coressponding COEP header

Comment 3

[Eden Chuang[:edenchuang]]

About the sub-test "fetch() to no CORP response should not succeed" of html/cross-origin-embedder-policy/require-corp-sw.https.html, I am not sure if it is a real fail or not.

Here's the fail message

assert_equals: expected "TypeError: Failed to fetch" but got "TypeError: NetworkError when attempting to fetch resource."

The fail is because the test expects a TypeError with the message "Failed to fetch", but we return a TypeError with "NetworkError when attempting to fetch resource." Maybe I missed something, the spec seems not to define the error message.

Anne, should we modify the test to check the error type only?

Comment 4

[Anne (:annevk)]

Yeah, that's bogus. Created https://github.com/web-platform-tests/wpt/pull/23907. (Feel free to push that fix here if that's easier. If you do that, leave comment on the PR so we can close it.)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c7a1a36d6d91
P2 ImportScript() in workers must respect the coressponding COEP header r=dom-workers-and-storage-reviewers,perry

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bc5cfb22c1d7
P1 Fix the web-platform-test html/cross-origin-embedder-policy/require-corp.https.html r=necko-reviewers,valentin

Comment 7

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/c7a1a36d6d91
https://hg.mozilla.org/mozilla-central/rev/bc5cfb22c1d7

Comment 8

[Cristina Coroiu [:ccoroiu]]

Backed out 2 changesets (bug 1642149) for perma wpt failures at /fetch/cross-origin-resource-policy/iframe-loads.html

Backout: https://hg.mozilla.org/integration/autoland/rev/a7234b23fcd3a015fba992bc9f233a8010e44033

Failure push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=bc5cfb22c1d7851e4992fe82a827db0b6f4c3137

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=306757954&repo=autoland&lineNumber=2594

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backout merged: https://hg.mozilla.org/mozilla-central/rev/a7234b23fcd3

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f5363f84fea6
P1 Fix the web-platform-test html/cross-origin-embedder-policy/require-corp.https.html r=necko-reviewers,valentin

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/00b1885544e9
P2 ImportScript() in workers must respect the coressponding COEP header r=dom-workers-and-storage-reviewers,perry

Comment 13

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/f5363f84fea6
https://hg.mozilla.org/mozilla-central/rev/00b1885544e9