Closed Bug 1642149 Opened 3 years ago Closed 3 years ago

Fix require-corp.https.html and require-corp-sw.https.html

Categories

(Core :: DOM: Networking, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla79
Tracking Status
firefox79 --- fixed

People

(Reporter: edenchuang, Assigned: edenchuang)

References

Details

(Whiteboard: [necko-triaged])

Attachments

(2 files)

Fix the web-platform-test
html/cross-origin-embedder-policy/require-corp.https.html
html/cross-origin-embedder-policy/require-corp-sw.https.html

Assignee: nobody → echuang
Blocks: 1631751
Severity: -- → S3
Status: NEW → ASSIGNED
Priority: -- → P2
Attachment #9153267 - Attachment description: Bug 1642149 - P2 ImportScript in worker must respect the coressponding COEP header → Bug 1642149 - P2 ImportScript() in workers must respect the coressponding COEP header

About the sub-test "fetch() to no CORP response should not succeed" of html/cross-origin-embedder-policy/require-corp-sw.https.html, I am not sure if it is a real fail or not.

Here's the fail message

assert_equals: expected "TypeError: Failed to fetch" but got "TypeError: NetworkError when attempting to fetch resource."

The fail is because the test expects a TypeError with the message "Failed to fetch", but we return a TypeError with "NetworkError when attempting to fetch resource." Maybe I missed something, the spec seems not to define the error message.

Anne, should we modify the test to check the error type only?

Flags: needinfo?(annevk)

Yeah, that's bogus. Created https://github.com/web-platform-tests/wpt/pull/23907. (Feel free to push that fix here if that's easier. If you do that, leave comment on the PR so we can close it.)

Flags: needinfo?(annevk)
Whiteboard: [necko-triaged]
Pushed by abutkovits@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c7a1a36d6d91
P2 ImportScript() in workers must respect the coressponding COEP header r=dom-workers-and-storage-reviewers,perry
Pushed by abutkovits@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bc5cfb22c1d7
P1 Fix the web-platform-test html/cross-origin-embedder-policy/require-corp.https.html r=necko-reviewers,valentin
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla79
Status: RESOLVED → REOPENED
Flags: needinfo?(echuang)
Resolution: FIXED → ---
Target Milestone: mozilla79 → ---
Pushed by rmaries@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f5363f84fea6
P1 Fix the web-platform-test html/cross-origin-embedder-policy/require-corp.https.html r=necko-reviewers,valentin
Pushed by rmaries@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/00b1885544e9
P2 ImportScript() in workers must respect the coressponding COEP header r=dom-workers-and-storage-reviewers,perry
Flags: needinfo?(echuang)
Status: REOPENED → RESOLVED
Closed: 3 years ago3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla79
You need to log in before you can comment on or make changes to this bug.