Closed Bug 1642176 Opened 5 years ago Closed 5 years ago

update-icu.sh shouldn't assume |python| is Python 2 and not 3

Categories

(Core :: JavaScript: Internationalization API, task, P2)

task

Tracking

()

RESOLVED FIXED
mozilla79
Tracking Status
firefox79 --- fixed

People

(Reporter: Waldo, Assigned: Waldo)

Details

Attachments

(2 files)

I'm writing some documentation for our use of ICU, tzdata, and all that jazz. A key part of that documentation, involves me re-figuring out all the necessary commands to update ICU and all related things.

Turns out, while Fedora 30 python was still Python 2, Fedora 32 (to which I recently updated) makes python be Python 3. And...stuff breaks. (Fedora 32 can't be the only distribution that acts this way now, by this point.)

The Python 2 dependencies seem to include mozbuild, pymake (which hasn't been touched apparently in years), and other stuff -- not merely the updating scripts themselves. So it seems best/necessary for now to just hard-code python2, tho at least one incompatibility was easy enough to fix that I'll patch it here.

Attachment #9152998 - Attachment description: Bug 1642176 - Hard-code python2 into update-icu.sh, because the various Python scripts that are invoked don't yet work with Python 3. r=anba! → Bug 1642176 - Hard-code python2 into update-icu.sh to run icu_sources_data.py, because it doesn't fully work with Python 3 yet. r=anba!
Attachment #9152999 - Attachment description: Bug 1642176 - Make intl/icu_sources_data.py Python 3-compatible. r=anba! → Bug 1642176 - Make intl/icu_sources_data.py itself Python 3-compatible. (Its dependencies, however, remain not fully Python 3-compatible.) r=anba!
Pushed by jwalden@mit.edu: https://hg.mozilla.org/integration/autoland/rev/a3a4b3c12784 Hard-code python2 into update-icu.sh to run icu_sources_data.py, because it doesn't fully work with Python 3 yet. r=anba https://hg.mozilla.org/integration/autoland/rev/0b321870afdb Make intl/icu_sources_data.py itself Python 3-compatible. (Its dependencies, however, remain not fully Python 3-compatible.) r=anba
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla79
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: