1642201 - Edit-and-Resend headers start with `undefined` and have two trailing newlines

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect, P1)

Description

[Johannes Pfrang [:johnp]]

What were you doing?

With a new profile on any page use the Edit-and-Resend functionality.

What happened?

The editable request headers look like this:

undefined
Host: [hostname removed]
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0
Accept: image/webp,*/*
Accept-Language: en-US,en;q=0.5
Accept-Encoding: gzip, deflate, br
Connection: keep-alive

This does not seem to affect the actually sent headers though.

What should have happened?

undefined and empty newlines should not be there if they were not in the original request.

Comment 1

[Hubert Boma Manilla (:bomsy)]

Thanks for the report!

Comment 2

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1642201 - Remove undefined and trim the headers for edit & resend r=honza

Comment 3

[Hubert Boma Manilla (:bomsy)]

This would probably need uplift.

Comment 4

[Jan Honza Odvarko [:Honza] (always need-info? me)]

(In reply to Hubert Boma Manilla (:bomsy) from comment #3)

This would probably need uplift.

Yes, 100% agree, thanks.
Honza

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7d33875e79bf
Remove undefined and trim the headers for edit & resend r=Honza

Comment 6

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/7d33875e79bf

Comment 7

[:Harald Kirschner :digitarald]

[Tracking Requested - why for this release]: Broken Edit-and-Resend in Network panel for cached responses.

Comment 8

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 9153029 [details]
Bug 1642201 - Remove undefined and trim the headers for edit & resend r=honza

Beta/Release Uplift Approval Request

• User impact if declined: Confuses web developers who wants to use "Edit and Resend" HTTP request feature
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Fix in developer tools, potential impact on web developers only, simple one liner patch.
• String changes made/needed:

Comment 9

[Julien Cristau [:jcristau]]

Comment on attachment 9153029 [details]
Bug 1642201 - Remove undefined and trim the headers for edit & resend r=honza

netmonitor regression fix, approved for 78.0b3

Comment 10

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/a81711950f48