Closed Bug 1642201 Opened 4 months ago Closed 4 months ago

Edit-and-Resend headers start with `undefined` and have two trailing newlines

Categories

(DevTools :: Netmonitor, defect, P1)

x86_64
Linux
defect

Tracking

(firefox-esr68 unaffected, firefox76 unaffected, firefox77 unaffected, firefox78+ fixed, firefox79 fixed)

RESOLVED FIXED
Firefox 79
Tracking Status
firefox-esr68 --- unaffected
firefox76 --- unaffected
firefox77 --- unaffected
firefox78 + fixed
firefox79 --- fixed

People

(Reporter: johnp, Assigned: bomsy)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression)

Attachments

(1 file)

What were you doing?

With a new profile on any page use the Edit-and-Resend functionality.

What happened?

The editable request headers look like this:

undefined
Host: [hostname removed]
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0
Accept: image/webp,*/*
Accept-Language: en-US,en;q=0.5
Accept-Encoding: gzip, deflate, br
Connection: keep-alive


This does not seem to affect the actually sent headers though.

What should have happened?

undefined and empty newlines should not be there if they were not in the original request.

Severity: -- → S3
Keywords: regression
Priority: -- → P1
Regressed by: 1622744

Thanks for the report!

Assignee: nobody → hmanilla
Status: NEW → ASSIGNED

This would probably need uplift.

(In reply to Hubert Boma Manilla (:bomsy) from comment #3)

This would probably need uplift.

Yes, 100% agree, thanks.
Honza

Pushed by hmanilla@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7d33875e79bf
Remove undefined and trim the headers for edit & resend r=Honza
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 79

[Tracking Requested - why for this release]: Broken Edit-and-Resend in Network panel for cached responses.

Comment on attachment 9153029 [details]
Bug 1642201 - Remove undefined and trim the headers for edit & resend r=honza

Beta/Release Uplift Approval Request

  • User impact if declined: Confuses web developers who wants to use "Edit and Resend" HTTP request feature
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Fix in developer tools, potential impact on web developers only, simple one liner patch.
  • String changes made/needed:
Attachment #9153029 - Flags: approval-mozilla-beta?

Comment on attachment 9153029 [details]
Bug 1642201 - Remove undefined and trim the headers for edit & resend r=honza

netmonitor regression fix, approved for 78.0b3

Attachment #9153029 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.