1642264 - [wpt-sync] Sync PR 23886 - [FlexNG] Treat specified intrinsic block size as auto for min-size: auto

Status: RESOLVED FIXED

(Core :: Layout: Flexbox, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 23886 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/23886
Details from upstream follow.

David Grogan <[e-mail]> wrote:

[FlexNG] Treat specified intrinsic block size as auto for min-size: auto

Previously FlexNG would give the item in this example min-height: 0, not
whatever the min-size: auto algorithm dictated.

\<div style="display: flex; flex-direction: column">
\<div style="min-height: min-content">
...

There's still a behavior difference from legacy flex containers because
they honor min-height: min-content[1]. NG always treats them as auto[2],
flex-minimum-height-flex-items-023.html demonstrates this. Looks like
this case already differs between Firefox and legacy, so hopefully
compat problems between FlexNG and legacy are few. It's still
unfortunate to introduce a third behavior for this case, even if the new
behavior is spec compliant.

[1] https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/renderer/core/layout/layout_box.cc;l=4039;drc=feef24515266f41efe38da79056a216a8ae9d459
[2] https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/renderer/core/layout/ng/ng_length_utils.cc;l=74;drc=feef24515266f41efe38da79056a216a8ae9d459

Bug: 1088223
Change-Id: I17f5f5dd55b159da04e9693c0992c9a635862eb1
Reviewed-on: https://chromium-review.googlesource.com/2224599
WPT-Export-Revision: 7b32138efe53d922d011c3b518f6328c8451804a

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=8ca9822704a5ababafb2dc69a7e864caf13c914c

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests

Status Summary

Firefox

PASS : 1
ERROR: 1

Chrome

FAIL : 2

Safari

PASS : 1
FAIL : 1

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-flexbox/flex-minimum-height-flex-items-023.html: ERROR (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/33b58297b643
[wpt PR 23886] - [FlexNG] Treat specified intrinsic block size as auto for min-size: auto, a=testonly
https://hg.mozilla.org/integration/autoland/rev/0e9d5f52f64e
[wpt PR 23886] - Update wpt metadata, a=testonly

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/33b58297b643
https://hg.mozilla.org/mozilla-central/rev/0e9d5f52f64e