Closed Bug 1642265 Opened 4 years ago Closed 4 years ago

[MIPS] fix build issues caused by recent updates (branchTestSymbol, fallibleUnboxPtr)

Categories

(Core :: JavaScript Engine: JIT, defect, P5)

Other
Unspecified
defect

Tracking

()

RESOLVED FIXED
mozilla79
Tracking Status
firefox-esr68 --- unaffected
firefox-esr78 --- fixed
firefox76 --- unaffected
firefox77 --- unaffected
firefox78 --- wontfix
firefox79 --- fixed

People

(Reporter: zhaojiazhong-hf, Assigned: zhaojiazhong-hf)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Failed to build js on mips machine due to some changes in D76827 and D76828.

Blocks: 1639895
Depends on: 1640829
Assignee: nobody → zhaojiazhong-hf
Severity: -- → S4
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Priority: -- → P5
Pushed by apavel@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d50b63346352 [MIPS64] Add branchTestSymbol and fallibleUnboxPtr to MacroAssembler. r=tcampbell
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla79
Blocks: 1684732

Comment on attachment 9153051 [details]
Bug 1642265 - [MIPS64] Add branchTestSymbol and fallibleUnboxPtr to MacroAssembler. r=tcampbell

ESR Uplift Approval Request

  • If this is not a sec:{high,crit} bug, please state case for ESR consideration: Failed to build firefox-esr78 on mips64 platform without this patch.
  • User impact if declined: Can't provide newest firefox-esr78 product on mips64 platform.
  • Fix Landed on Version: firefox79
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): This patch just adds some missing functions in mips-only files.
  • String or UUID changes made by this patch:
Attachment #9153051 - Flags: approval-mozilla-esr78?

Comment on attachment 9153051 [details]
Bug 1642265 - [MIPS64] Add branchTestSymbol and fallibleUnboxPtr to MacroAssembler. r=tcampbell

Approved for 78.7esr.

Attachment #9153051 - Flags: approval-mozilla-esr78? → approval-mozilla-esr78+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: