1642300 - Remove redundant entries from nsISearchService.idl

Status: RESOLVED FIXED

(Firefox :: Search, task, P2)

Description

[Mark Banner (:standard8)]

nsISearchService.idl has several items that are no longer required, or no longer required to be exposed:

• SEARCH_ENGINE_* constants
  • These are not used anywhere, I don't think we need the overhead of defining them for c++. They are listed in SearchUtils
• nsISearchService:getEngineParams
  • This is not used externally to the search service, and we'd like to combine it into other things (bug 1637744)
• nsISearchService.hasEngineWithURL
  • This is completely unused (apart from its test) and I don't see us needing it soon.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1642300 - Remove nsISearchService.hasEngineWithURL. r?daleharvey!

Depends on D77650

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1642300 - Un-expose nsISearchService.getEngineParams and tidy up. r?daleharvey!

Depends on D77651

Comment 3

[Mark Banner (:standard8)]

Attachment: Bug 1642300 - Remove unused c++ defines in nsISearchService.idl. r?daleharvey!

Depends on D77652

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/af266858e75b
Remove nsISearchService.hasEngineWithURL. r=daleharvey
https://hg.mozilla.org/integration/autoland/rev/46f8cd8f4972
Un-expose nsISearchService.getEngineParams and tidy up. r=daleharvey
https://hg.mozilla.org/integration/autoland/rev/fdbacdb44aa4
Remove unused c++ defines in nsISearchService.idl. r=daleharvey

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/af266858e75b
https://hg.mozilla.org/mozilla-central/rev/46f8cd8f4972
https://hg.mozilla.org/mozilla-central/rev/fdbacdb44aa4