Closed Bug 1642300 Opened 3 years ago Closed 3 years ago

Remove redundant entries from nsISearchService.idl

Categories

(Firefox :: Search, task, P2)

Product:
Firefox
Component:
Search
Type:
task
Points:
3

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 79
Iteration:
79.1 - June 1 - June 14
Tracking Flags:
Tracking Status
firefox79 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(3 files)

Bug 1642300 - Remove nsISearchService.hasEngineWithURL. r?daleharvey!
47 bytes, text/x-phabricator-request
Details | Review
Bug 1642300 - Un-expose nsISearchService.getEngineParams and tidy up. r?daleharvey!
47 bytes, text/x-phabricator-request
Details | Review
Bug 1642300 - Remove unused c++ defines in nsISearchService.idl. r?daleharvey!
47 bytes, text/x-phabricator-request
Details | Review

nsISearchService.idl has several items that are no longer required, or no longer required to be exposed:

  • SEARCH_ENGINE_* constants
    • These are not used anywhere, I don't think we need the overhead of defining them for c++. They are listed in SearchUtils
  • nsISearchService:getEngineParams
    • This is not used externally to the search service, and we'd like to combine it into other things (bug 1637744)
  • nsISearchService.hasEngineWithURL
    • This is completely unused (apart from its test) and I don't see us needing it soon.
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/af266858e75b
Remove nsISearchService.hasEngineWithURL. r=daleharvey
https://hg.mozilla.org/integration/autoland/rev/46f8cd8f4972
Un-expose nsISearchService.getEngineParams and tidy up. r=daleharvey
https://hg.mozilla.org/integration/autoland/rev/fdbacdb44aa4
Remove unused c++ defines in nsISearchService.idl. r=daleharvey
You need to log in before you can comment on or make changes to this bug.