1642306 - Tidy filter.py following switch to JSON for search

Status: ASSIGNED

(SeaMonkey :: Build Config, task)

Description

[Ian Neal]

Following the landing of Bug 1300198, l10n.toml and filter.py probably need tidying up.

Comment 1

[Ian Neal]

Attachment: Tidy up

Requesting feedback as want to make sure this won't break anything for pontoon, cross-repo, etc.

Comment 2

[Francesco Lodolo [:flod]]

I wanted to redirect this to Pike, but I have no way to do it in Bugzilla…

filter.py looks good to me, I think you should keep the l10n.toml as is for now, and file a follow-up bug to remove it once we stop tracking all trees that include the old search system.

Comment 3

[Ian Neal]

Comment on attachment 9153122 [details] [diff] [review]
Tidy up

Redirecting to Pike

Comment 4

[Axel Hecht [:Pike]]

Comment on attachment 9153122 [details] [diff] [review]
Tidy up

Review of attachment 9153122 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah, l10n.toml controls cross-channel, we need to hold those changes until they're out of shipping.

Also, this patch is a good example of why we don't merge l10n.toml, aside from toml being hard. The removal of an ignore is a double negative, and that's culturally hard ;-) Aka, I haven't burnt a brain or two on figuring that out.