Closed
Bug 1642318
Opened 4 years ago
Closed 4 years ago
network.http.sanitize-headers-in-logs should be RelaxedAtomicBool
Categories
(Core :: Networking, defect, P2)
Core
Networking
Tracking
()
RESOLVED
FIXED
mozilla79
| Tracking | Status | |
|---|---|---|
| firefox-esr68 | --- | unaffected |
| firefox76 | --- | unaffected |
| firefox77 | --- | unaffected |
| firefox78 | --- | fixed |
| firefox79 | --- | fixed |
People
(Reporter: valentin, Assigned: valentin)
References
(Regression)
Details
(Keywords: regression, Whiteboard: [necko-triaged])
Attachments
(1 file)
|
47 bytes,
text/x-phabricator-request
|
jcristau
:
approval-mozilla-beta+
|
Details | Review |
No description provided.
|
Assignee | |
Comment 1•4 years ago
|
||
|
|
Assignee | |
Comment 2•4 years ago
•
|
||
Comment on attachment 9153131 [details]
Bug 1642318 - network.http.sanitize-headers-in-logs should be RelaxedAtomicBool r=#necko
Beta/Release Uplift Approval Request
- User impact if declined: Assertion when logging
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Just makes the static pref getter be atomic so we can access it off the main thread.
- String changes made/needed:
Attachment #9153131 -
Flags: approval-mozilla-beta?
|
||
Comment 3•4 years ago
|
||
Whoops, sorry! I guess automation never stretches this path..?
Pushed by valentin.gosu@gmail.com: https://hg.mozilla.org/integration/autoland/rev/5fea66fd4fac network.http.sanitize-headers-in-logs should be RelaxedAtomicBool r=necko-reviewers,mayhemer
|
||
Updated•4 years ago
|
status-firefox76:
--- → unaffected
status-firefox77:
--- → unaffected
status-firefox78:
--- → affected
status-firefox79:
--- → affected
status-firefox-esr68:
--- → unaffected
|
|
||
Comment 5•4 years ago
|
||
Comment on attachment 9153131 [details]
Bug 1642318 - network.http.sanitize-headers-in-logs should be RelaxedAtomicBool r=#necko
approved for 78.0b2
Attachment #9153131 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
|
||
Comment 7•4 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla79
|
|
||
Comment 8•4 years ago
|
||
| bugherder uplift | ||
|
||
Updated•4 years ago
|
Has Regression Range: --- → yes
Keywords: regression
You need to log in
before you can comment on or make changes to this bug.
Description
•