Closed
Bug 1642332
Opened 4 years ago
Closed 4 years ago
[MIPS] Number.NaN returns 0 on MIPS
Categories
(Core :: JavaScript Engine, defect, P5)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla79
| Tracking | Status | |
|---|---|---|
| firefox-esr68 | --- | unaffected |
| firefox-esr78 | --- | fixed |
| firefox76 | --- | unaffected |
| firefox77 | --- | unaffected |
| firefox78 | --- | wontfix |
| firefox79 | --- | fixed |
People
(Reporter: tcampbell, Assigned: tcampbell)
References
(Blocks 1 open bug, Regression)
Details
(Keywords: regression)
Attachments
(1 file)
|
47 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-esr78+
|
Details | Review |
The JS_RUNTIME_CANONICAL_NAN work-around initializes NaN after the static initializer for Number.NaN runs, giving wrong value. https://searchfox.org/mozilla-central/rev/5e4d4827aa005d031580d2d17a01bae1af138b2e/js/src/jsnum.cpp#1278
|
Assignee | |
Comment 1•4 years ago
|
||
|
||
Comment 2•4 years ago
|
||
Set release status flags based on info from the regressing bug 1430693
status-firefox77:
--- → unaffected
status-firefox78:
--- → affected
status-firefox79:
--- → affected
status-firefox-esr68:
--- → unaffected
|
||
Updated•4 years ago
|
Assignee: nobody → tcampbell
Attachment #9153148 -
Attachment description: Bug 1642332 - Avoid static initializer for Number.NaN → Bug 1642332 - Avoid static initializer for Number.NaN r?jandem
Status: NEW → ASSIGNED
|
|
||
Updated•4 years ago
|
Keywords: regression
Pushed by tcampbell@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a99ed7e04b94 Avoid static initializer for Number.NaN r=jandem
|
||
Comment 4•4 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla79
|
||
Updated•4 years ago
|
status-firefox76:
--- → unaffected
|
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Comment 6•4 years ago
|
||
Comment on attachment 9153148 [details]
Bug 1642332 - Avoid static initializer for Number.NaN r?jandem
ESR Uplift Approval Request
- If this is not a sec:{high,crit} bug, please state case for ESR consideration: This is a low-risk change to fix a correctness issue on MIPS builds.
- User impact if declined:
Number.NaNreturns wrong value on MIPS platforms. - Fix Landed on Version: 79
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Minor change that has been stable for a few cycles.
- String or UUID changes made by this patch:
Flags: needinfo?(tcampbell)
Attachment #9153148 -
Flags: approval-mozilla-esr78?
|
|
Assignee | |
Comment 7•4 years ago
|
||
Patch grafts cleanly to esr78.
|
|
||
Comment 8•4 years ago
|
||
Comment on attachment 9153148 [details]
Bug 1642332 - Avoid static initializer for Number.NaN r?jandem
Approved for 78.4esr.
Attachment #9153148 -
Flags: approval-mozilla-esr78? → approval-mozilla-esr78+
|
|
||
Comment 9•4 years ago
|
||
| bugherder uplift | ||
status-firefox-esr78:
--- → fixed
|
||
Updated•4 years ago
|
Has Regression Range: --- → yes
You need to log in
before you can comment on or make changes to this bug.
Description
•