1642350 - [wpt-sync] Sync PR 23891 - Use text-decoration-thickness value in underline painting

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 23891 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/23891
Details from upstream follow.

Dominik Röttsches <[e-mail]> wrote:

Use text-decoration-thickness value in underline painting

Parsing of text-decoration-thickness was added in [1], use the parsed
value in text decoration thickness painting.

Add a WPT ref test that compares text-decoration-thickness value from a
variable font (keyword value 'from-font' for text-decoration-thickness)
with the identical rendering achieved by using a static font with thick
and thin underline metadata.

Add a second WPT ref test that compares a fixed
text-decoration-thickness value to the from-font values of a font with
thick and thin underlines.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/2178888

Bug: 785230
Change-Id: I626a321a38c77e106215b640dcf85c20f7a0ad93
Reviewed-on: https://chromium-review.googlesource.com/2218119
WPT-Export-Revision: 6c299489edf1abd9913ffd59e24f850fcdb7df91

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=ae283d9467c7c1c803571727620c77e57a6f4f21

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests

Status Summary

Firefox

ERROR: 3

Chrome

PASS : 2
FAIL : 1

Safari

PASS : 1
FAIL : 2

Links

GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/css/css-text-decor/text-decoration-thickness-from-font-variable.html: ERROR

New Tests That Don't Pass

/css/css-text-decor/text-decoration-thickness-fixed.html: ERROR (Chrome: PASS, Safari: FAIL)
/css/css-text-decor/text-decoration-thickness-ink-skip-dilation.html: ERROR (Chrome: FAIL, Safari: FAIL)
/css/css-text-decor/text-decoration-thickness-from-font-variable.html: ERROR (Chrome: PASS, Safari: PASS)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f710fc9cb877
[wpt PR 23891] - Use text-decoration-thickness value in underline painting, a=testonly
https://hg.mozilla.org/integration/autoland/rev/f1ade83bccc2
[wpt PR 23891] - Update wpt metadata, a=testonly

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/f710fc9cb877
https://hg.mozilla.org/mozilla-central/rev/f1ade83bccc2