1642351 - merge action task shouldn't schedule source-test tasks

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Rail Aliiev [:rail]]

As an example, running "bump-esr" off of mozilla-central creates some source-test on the central branch, https://firefox-ci-tc.services.mozilla.com/tasks/IXlmv62BRYKczLVvMnPfLg. This is probably redundant.

[task 2020-06-01T02:45:01.277Z] writing artifact file `label-to-taskid.json`
[task 2020-06-01T02:45:01.278Z] Creating task with taskId aRgg0tSIRbePkvpXavEvtA for source-test-mozlint-eslint
[task 2020-06-01T02:45:01.280Z] Creating task with taskId dhrzSfs4R_yBipL9tdCwGg for source-test-mozlint-clang-format
[task 2020-06-01T02:45:01.281Z] Creating task with taskId ZR8129AvTKOtrlfkrr8SfA for source-test-mozlint-file-whitespace
[task 2020-06-01T02:45:01.282Z] Creating task with taskId dZXHZAYOTNq7GIvszI8p6Q for source-test-mozlint-codespell
[task 2020-06-01T02:45:01.285Z] Creating task with taskId MA7QOlS8QTas-yyQ7kfAwQ for source-test-mozlint-license
[task 2020-06-01T02:45:01.287Z] Creating task with taskId OjtwQaakT_aVCpFeDk-r8Q for source-test-mozlint-cpp-virtual-final
[task 2020-06-01T02:45:01.288Z] Creating task with taskId IeUiFw6uT1S8mi21slkVoA for source-test-mozlint-mingw-cap
[task 2020-06-01T02:45:01.288Z] Creating task with taskId J2JpPJ5RR_CDWMy0iRK77A for merge-bump-esr
[task 2020-06-01T02:45:01.291Z] Creating task with taskId NG1BXyJTSfiVU8gagJNDpA for source-test-mozlint-file-perm

Comment 1

[Simon Fraser [:sfraser] ⌚️GMT]

The source tests run depend on the files that were changed in the associated push, and actions depend on an existing task group.

This will likely be a change to https://searchfox.org/mozilla-central/source/taskcluster/taskgraph/optimize/strategies.py#46-58 so that it understands that for some sort of action tasks, it shouldn't consult the files that were changed in the push. Perhaps checking params.get("merge_config") or the target_tasks_method?

Comment 2

[Tom Prince [:tomprince]]

I think the solution is to set tasks_for to action, in both the merge and rel-pro actions, rather than inheriting hg-push from the push task. That triggers this code, which is what adds most of the lint tasks to the graph.

Comment 3

[Simon Fraser [:sfraser] ⌚️GMT]

Good call, that worked on try just now.

Comment 4

[Simon Fraser [:sfraser] ⌚️GMT]

Attachment: Bug 1642351 Set tasks_for in merge automation action to prevent source-tests

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/16a9d99adb43
Set tasks_for in merge automation action to prevent source-tests r=rail

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/16a9d99adb43