1642387 - Avoid timeouts within HTTPS-Only Mode by sending background http request

Status: RESOLVED FIXED

(Core :: DOM: Security, defect, P2)

Description

[Arthur Edelstein [:arthur]]

Attachment: Screen Shot 2020-06-01 at 9.58.41 AM.png

Steps to reproduce:

1. Set dom.security.https_only_mode to true
2. Enter "people.cn" in the URL bar

Actual results:
The browser waits for 90 seconds and then shows the "Secure Connection Unavailable" error page, with a "Timed Out" status bar message. During this time, the user can get the impression that the website isn't working at all.

Desired results:
The browser rapidly shows the "Secure Connection Unavailable" error page. If that isn't possible, then a non-blocking notification bar or doorhanger that gives the user an option to "Accept the Risk and Continue to Site" before waiting the full 90 seconds.

Comment 1

[Julian Gaibler]

Hi Arthur,
thanks for opening this bug! I'll look into fixing this ^^

Comment 2

[Arthur Edelstein [:arthur]]

Thanks, Julian!

Another website with the same behavior:
moonlander.seb.ly

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:ckerschb, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 4

[Arthur Edelstein [:arthur]]

I assume websites like this are not responding at all to HTTPS requests. One idea for fixing this failure mode might be: if no response is received from an upgraded HTTPS connection attempt after 500 ms (or similar timeout), send an HTTP request in the background. If we then receive an HTTP response before any HTTPS response, show the HTTPS Only Mode error page.

Comment 5

[Arthur Edelstein [:arthur]]

Another site:
http://speedofanimals.com

Comment 6

[Arthur Edelstein [:arthur]]

Another site:
http://randomwalker.info

Comment 8

[Christoph Kerschbaumer [:ckerschb]]

Attachment: Bug 1642387: Prevent HTTPS-Only timeouts by sending http request in the background with a 3000ms delay. If that http request returns before the upgraded request, it's an indicator the https request will result in a timeout and we show the error...

...page instead. r=dragana

Comment 9

[Christoph Kerschbaumer [:ckerschb]]

Attachment: Bug 1642387: Prevent HTTPS-Only timeouts tests.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5349b1df5595
Prevent HTTPS-Only timeouts tests. r=JulianWels
https://hg.mozilla.org/integration/autoland/rev/f09be3d0ab1b
Prevent HTTPS-Only timeouts by sending http request in the background with a 500ms delay. If that http request returns before the upgraded request, it's an indicator the https request will result in a timeout and we show the error... r=mattwoodrow,dragana,JulianWels

Comment 11

[Razvan Maries]

Backed out for perma failures.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedTaskRun=VdbzZl9TSfW4U0oR4jfwoQ.0&resultStatus=testfailed%2Cbusted%2Cexception&revision=f09be3d0ab1bc7b6a1cea9b5c52556682a12cedc&searchStr=linux%2C18.04%2Cx64%2Cdebug%2Cmochitests%2Ctest-linux1804-64%2Fdebug-mochitest-browser-chrome-e10s%2Cbc11

Log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=312621185&repo=autoland&lineNumber=14620

Backout: https://hg.mozilla.org/integration/autoland/rev/3356b4e765e7598963fe0a62d80d889c221eaae9

Comment 12

[Christoph Kerschbaumer [:ckerschb]]

(In reply to Razvan Maries from comment #11)

Backed out for perma failures.

Huh, is that really a perma failure? I can't imagine because it works locally on mac and linux. Currently I can't reproduce the problem. I'll see what I can do here.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d31509a36f35
Prevent HTTPS-Only timeouts tests. r=JulianWels
https://hg.mozilla.org/integration/autoland/rev/863cf62af994
Prevent HTTPS-Only timeouts by sending http request in the background with a 3000ms delay. If that http request returns before the upgraded request, it's an indicator the https request will result in a timeout and we show the error... r=mattwoodrow,dragana,JulianWels

Comment 14

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/d31509a36f35
https://hg.mozilla.org/mozilla-central/rev/863cf62af994