1642397 - Source Tree hides files with similar names

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P2)

Description

[:Harald Kirschner :digitarald]

Attachment: Chrome vs Firefox vs Firefox file search

What were you doing?

1. Open a vue project like https://h160t.csb.app/
2. Open App.vue via Search or Source Tree

What happened?

App.vue shows up only mapped in source tree, while search shows many more results.

What should have happened?

Complete list in Source Tree and better indicators in Search on which file is source-mapped.

Comment 2

[:Harald Kirschner :digitarald]

https://vue-vuex-realworld.netlify.app/ is another great example of this.

If you want to open the Home component, webpack:///src/views/Home.vue?493c gets shown by default in the Source Tree while webpack:///src/views/Home.vue is the vue file a developer would want to see. webpack:///src/views/Home.vue?f01b is also in search, but only contains the compiled vue template. I guess either the last or first entry that comes in wins and replaces all others.

The source map seems to have issues, but I can't tell for sure how severe they are: https://sourcemaps.io/report/1591048717188_https%3A%2F%2Fvue-vuex-realworld.netlify.app%2Fjs%2Fapp.7ca7b6fc.js

Comment 3

[:Harald Kirschner :digitarald]

More debugging – I opened webpack:///src/components/ArticleMeta.vue on https://vue-vuex-realworld.netlify.app/ (via pausing on click). The Source Tree does not highlight the file in the tree on open and Reveal in tree also doesn't work when used on the tab.

Comment 4

[:Harald Kirschner :digitarald]

Confirmed that this is the issue affecting most vue.js setups: https://github.com/webpack/webpack/issues/1194#issuecomment-638401263

Comment 5

[Logan Smyth [:loganfsmyth]]

Attachment: Bug 1642397 - Part 1: Handle unparseable URLs more consistently and handle query params. r=jlast!

Comment 6

[Logan Smyth [:loganfsmyth]]

Attachment: Bug 1642397 - Part 2: Only pass sources-tree a query param if it should use it. r=jlast!

Depends on D81266

Comment 7

[Logan Smyth [:loganfsmyth]]

Attachment: Bug 1642397 - Part 3: Show query string in SourcesTree when files conflict. r=jlast!

Depends on D81267

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b240470c554b
Part 1: Handle unparseable URLs more consistently and handle query params. r=jlast,davidwalsh
https://hg.mozilla.org/integration/autoland/rev/fa25bc61d997
Part 2: Only pass sources-tree a query param if it should use it. r=jlast,davidwalsh
https://hg.mozilla.org/integration/autoland/rev/c00459529ec8
Part 3: Show query string in SourcesTree when files conflict. r=jlast,davidwalsh

Comment 9

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/b240470c554b
https://hg.mozilla.org/mozilla-central/rev/fa25bc61d997
https://hg.mozilla.org/mozilla-central/rev/c00459529ec8