1642418 - Perma tier 2 0:37.27 python/mach/mach/test/test_commands.py::TestCommands::test_mach_completion TEST-UNEXPECTED-FAIL

Status: RESOLVED FIXED

(Firefox Build System :: General, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: rmaries [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=304578737&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/BBC84l-BRzCpuRmkkCwFqQ/runs/0/artifacts/public/logs/live_backing.log

---

[task 2020-06-01T18:03:24.528Z] 0:37.26 ============================= test session starts ==============================
[task 2020-06-01T18:03:24.528Z] 0:37.26 platform darwin -- Python 2.7.10, pytest-3.6.2, py-1.5.4, pluggy-0.6.0 -- /Users/cltbld/tasks/task_1591034226/checkouts/gecko/obj-x86_64-apple-darwin18.6.0/_virtualenvs/gecko-OZUQ9VZ--2/bin/python
[task 2020-06-01T18:03:24.530Z] 0:37.26 rootdir: /Users/cltbld/tasks/task_1591034226/checkouts/gecko, inifile: /Users/cltbld/tasks/task_1591034226/checkouts/gecko/config/mozunit/mozunit/pytest.ini
[task 2020-06-01T18:03:24.534Z] 0:37.26 collecting ... collected 2 items
[task 2020-06-01T18:03:24.535Z] 0:37.27
[task 2020-06-01T18:03:24.537Z] 0:37.27 python/mach/mach/test/test_commands.py::TestCommands::test_mach_completion TEST-UNEXPECTED-FAIL
[task 2020-06-01T18:03:24.537Z] 0:37.27 python/mach/mach/test/test_commands.py::TestCommands::test_print_command PASSED
[task 2020-06-01T18:03:24.537Z] 0:37.27
[task 2020-06-01T18:03:24.537Z] 0:37.27 =================================== FAILURES ===================================
[task 2020-06-01T18:03:24.538Z] 0:37.27 ______________________ TestCommands.test_mach_completion _______________________
[task 2020-06-01T18:03:24.538Z] 0:37.27
[task 2020-06-01T18:03:24.543Z] 0:37.27 self = <mach.test.test_commands.TestCommands testMethod=test_mach_completion>
[task 2020-06-01T18:03:24.559Z] 0:37.29
[task 2020-06-01T18:03:24.559Z] 0:37.29 def test_mach_completion(self):
[task 2020-06-01T18:03:24.559Z] 0:37.29 result, stdout, stderr = self._run_mach(['mach-completion'])
[task 2020-06-01T18:03:24.559Z] 0:37.29 assert result == 0
[task 2020-06-01T18:03:24.559Z] 0:37.29 > assert stdout == self.format(self.all_commands)
[task 2020-06-01T18:03:24.559Z] 0:37.29 E AssertionError: assert 'cmd_foo\nmach...bug-commands\n' == 'cmd_bar\ncmd_f...bug-commands\n'
[task 2020-06-01T18:03:24.559Z] 0:37.29 E + cmd_bar
[task 2020-06-01T18:03:24.559Z] 0:37.29 E cmd_foo
[task 2020-06-01T18:03:24.559Z] 0:37.29 E + cmd_foobar
[task 2020-06-01T18:03:24.559Z] 0:37.29 E mach-commands
[task 2020-06-01T18:03:24.559Z] 0:37.29 E mach-completion
[task 2020-06-01T18:03:24.559Z] 0:37.29 E mach-debug-commands
[task 2020-06-01T18:03:24.559Z] 0:37.29
[task 2020-06-01T18:03:24.559Z] 0:37.29 python/mach/mach/test/test_commands.py:41: AssertionError
[task 2020-06-01T18:03:24.559Z] 0:37.29 ====================== 1 failed, 1 passed in 0.10 seconds ======================
[task 2020-06-01T18:03:24.559Z] 0:37.29 Setting retcode to 1 from /Users/cltbld/tasks/task_1591034226/checkouts/gecko/python/mach/mach/test/test_commands.py
[task 2020-06-01T18:03:24.559Z] 0:37.29 /Users/cltbld/tasks/task_1591034226/checkouts/gecko/python/mach/mach/test/test_conditions.py

Comment 1

[Razvan Maries]

Ricky, could you take alook?

Comment 2

[Ricky Stewart]

Attachment: Bug 1642418 - Fix mach completion unit test by updating bad conditional

I misinterpreted one of the conditionals when working on bug 1641991 (the "not X or Y" formulation confused me :( ). The correct fix here is to remove this conditional which isn't relevant any more after we removed all the old pre-mochitest mach command.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a7ee7cb5e874
Fix mach completion unit test by updating bad conditional r=froydnj

Comment 4

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/a7ee7cb5e874

Comment 5

[Intermittent Failures Robot]

9 failures in 4949 pushes (0.002 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 9

Platform breakdown:

• macosx1014-64: 2
• windows10-64: 5
• linux1804-64: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1642418&startday=2020-06-01&endday=2020-06-07&tree=all