1642425 - nsGlobalWindowOuter::IsTopLevelWindow() and nsGlobalWindowOuter::IsFrame() don't work in Fission

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect)

Description

[Olli Pettay [:smaug][[e-mail]] (vacation-ish -> Aug 1)]

Especially IsFrame is used in various places, so need to audit those.

Comment 1

[Kris Maglione [:kmag]]

Attachment: Bug 1642425: Part 1 - Remove IsTopLevelWindow() method. r=smaug

It doesn't do anything sensible under Fission.

Comment 2

[Kris Maglione [:kmag]]

Attachment: Bug 1642425: Part 2 - Remove IsFrame() from GlobalWindow(Inner|Outer). r=smaug

It does not return sensible values under Fission.

Comment 3

[Kris Maglione [:kmag]]

Attachment: Bug 1642425: Part 3 - Fix nsDocLoader::GetIsTopLevel under Fission. r=smaug

Comment 4

[Kris Maglione [:kmag]]

Attachment: Bug 1642425: Part 4 - Fix mTopLevelOuterContentWindow under Fission. r=smaug

Comment 5

[Kris Maglione [:kmag]]

Attachment: Bug 1642425: Part 5 - Update comments to account for Fission. r=smaug

Comment 6

[Kris Maglione [:kmag]]

Attachment: Bug 1642425: Part 6 - Fix spurious use of GetInProcessParent(). r=smaug

Comment 7

[Chris Peterson [:cpeterson]]

Tracking for Fission Nightly M6a

Blocking GetInProcess* audit bug 1642433

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:kmag, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2d043642d1b7
Part 1 - Remove IsTopLevelWindow() method. r=baku
https://hg.mozilla.org/integration/autoland/rev/b2c3918a9311
Part 2 - Remove IsFrame() from GlobalWindow(Inner|Outer). r=smaug
https://hg.mozilla.org/integration/autoland/rev/a08ad3458974
Part 3 - Fix nsDocLoader::GetIsTopLevel under Fission. r=smaug
https://hg.mozilla.org/integration/autoland/rev/f175ad18920d
Part 4 - Fix mTopLevelOuterContentWindow under Fission. r=smaug
https://hg.mozilla.org/integration/autoland/rev/61a347c58edd
Part 5 - Update comments to account for Fission. r=smaug
https://hg.mozilla.org/integration/autoland/rev/34de0e6f8e25
Part 6 - Fix spurious use of GetInProcessParent(). r=smaug

Comment 10

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/2d043642d1b7
https://hg.mozilla.org/mozilla-central/rev/b2c3918a9311
https://hg.mozilla.org/mozilla-central/rev/a08ad3458974
https://hg.mozilla.org/mozilla-central/rev/f175ad18920d
https://hg.mozilla.org/mozilla-central/rev/61a347c58edd
https://hg.mozilla.org/mozilla-central/rev/34de0e6f8e25