1642449 - Remove reference to WebrtcIPCTraits from WebrtcGlobal

Status: RESOLVED FIXED

(Core :: WebRTC, defect, P1)

Description

[Nico Grunbaum [:ng, @chew:mozilla.org]]

I suspect that this addition was uneccessary and caused build errors when compiling against macOS 10.15 SDK.

Comment 1

[Nico Grunbaum [:ng, @chew:mozilla.org]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f2cc89414f009f1741fbc2f8b814bef996000a4c

Comment 2

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1642449 - remove reference to WebrtcIPCTraits;r?dminor

Comment 3

[Nico Grunbaum [:ng, @chew:mozilla.org]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=491944ccef0212ba5271bab699c26fdb6a5345d3

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a572a1bd5376
remove reference to WebrtcIPCTraits;r=dminor

Comment 5

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/a572a1bd5376

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Is this something we wanted to uplift to Beta given bug 1642266? 78 is what our next ESR release will be.

Comment 7

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Comment on attachment 9153229 [details]
Bug 1642449 - remove reference to WebrtcIPCTraits;r?dminor

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: This is a build fix, that removes an unnecessary include which prevents a build failure. It is an alternate fix for the problem in bug 1642266, but at higher level.
• User impact if declined: Low impact, there is an alternate build fix though this one is "more correct".
• Fix Landed on Version: 79
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This removes an extraneous include. If problematic it very likely that problems would occur at build time.
• String or UUID changes made by this patch: None

Comment 8

[Nico Grunbaum [:ng, @chew:mozilla.org]]

This is not critical to uplift, unless esr68 is seeing the build failures from bug 1642266, but it would be nice to have the more correct fix in place.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9153229 [details]
Bug 1642449 - remove reference to WebrtcIPCTraits;r?dminor

Hi, Nico, the request was for Beta uplift since 78 is going to be the next ESR release, not for the current one :)

Comment 10

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Comment on attachment 9153229 [details]
Bug 1642449 - remove reference to WebrtcIPCTraits;r?dminor

Beta/Release Uplift Approval Request

• User impact if declined: None
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It is a build error fix that if errors were to occur would almost certainly be at build time.
• String changes made/needed: None

Comment 11

[Nico Grunbaum [:ng, @chew:mozilla.org]]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #9)

Comment on attachment 9153229 [details]
Bug 1642449 - remove reference to WebrtcIPCTraits;r?dminor

Hi, Nico, the request was for Beta uplift since 78 is going to be the next ESR release, not for the current one :)

Heh, sorry.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9153229 [details]
Bug 1642449 - remove reference to WebrtcIPCTraits;r?dminor

Fixes macOS build bustage, approved for 78.0b6.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/17ab511f6880