1642454 - Port OS.File read/writeAtomic to C++

Status: RESOLVED FIXED

(Toolkit Graveyard :: OS.File, task)

Description

[Keefer Rourke]

Part of larger work to port OS.File to C++, we'd like to define a small Web IDL interface to implement static read/writeAtomic methods (which are the most used methods of the OS.File API) in C++.

Comment 1

[Keefer Rourke]

Attachment: Bug 1642454: Implement IOUtils read and writeAtomic methods r=barret,smaug,Gijs

Comment 2

[Keefer Rourke]

Attachment: Bug 1642454: Move PR_CloseDelete to dom/system r=barret,smaug

The class PR_CloseDelete is a useful deletor for automatically closing NSPR File
Descriptors when used with UniquePtr. This patch extracts this class from
nsTerminator.cpp to a new module at toolkit/library/nsprutil so it may be used
by new code.

Comment 3

[Keefer Rourke]

Attachment: Bug 1642454: Explicitly list copy and move assignment and ctor in PR_CloseDelete r=barret,smaug

Depends on D80719

Comment 4

[Keefer Rourke]

Attachment: Bug 1642454: Promote worker testing functions to mochitest/tests/SimpleTest r=barret,gbrown

This patch extracts some functions from OS.File tests to
mochitest/tests/SimpleTest to be more readily used by new code which needs to
run tests in ChromeWorkers.

Depends on D80896

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dfb201663480
Move PR_CloseDelete to dom/system r=barret,smaug
https://hg.mozilla.org/integration/autoland/rev/1e68090eed0b
Explicitly list copy and move assignment and ctor in PR_CloseDelete r=barret,smaug
https://hg.mozilla.org/integration/autoland/rev/7896b4315920
Promote worker testing functions to mochitest/tests/SimpleTest r=gbrown
https://hg.mozilla.org/integration/autoland/rev/13553531fc62
Implement IOUtils read and writeAtomic methods r=barret,smaug,Gijs

Comment 6

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dd44f8b0b7dc
Backed out 4 changesets for failures on dom/system/tests/test_ioutils_worker.xhtml . CLOSED TREE

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7deedab9e8d3
Move PR_CloseDelete to dom/system r=barret,smaug
https://hg.mozilla.org/integration/autoland/rev/05642361f23b
Explicitly list copy and move assignment and ctor in PR_CloseDelete r=barret,smaug
https://hg.mozilla.org/integration/autoland/rev/5b0c6f346230
Promote worker testing functions to mochitest/tests/SimpleTest r=gbrown
https://hg.mozilla.org/integration/autoland/rev/14af8a35e823
Implement IOUtils read and writeAtomic methods r=barret,smaug,Gijs

Comment 8

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/7deedab9e8d3
https://hg.mozilla.org/mozilla-central/rev/05642361f23b
https://hg.mozilla.org/mozilla-central/rev/5b0c6f346230
https://hg.mozilla.org/mozilla-central/rev/14af8a35e823