1642461 - Format logged ClojureScript data structures

Status: NEW

(DevTools :: Console, enhancement, P3)

Description

[:Harald Kirschner :digitarald]

Chrome DevTools' Custom Formatters feature is not secure and seems to be only used by ClojureScript DevTools. We still want to unblock CLJS developers to have a better experience with DevTools, similar how we format framework stacks and identify frameworks for file icons.

The basic idea that we want to validate is implementing CLJS' formatters as DevTools reps.

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

I'd be happy to mentor anyone who wants to implement this.
The first thing to do would be to do an inventory of the different type of ClojureScript objects that can be rendered, so we can split that bug into multiple smaller ones for each type of object.

Comment 2

[mariano]

It's also used for immutable.js https://chrome.google.com/webstore/detail/immutablejs-object-format/hgldghadipiblonfkkicmgcbbijnpeog

Comment 3

[mariano]

Types for immutable js: List, Map, Ordered Map, Seq, Record, Set, Ordered Set, Stack, Seq. Should be pretty similar in clojurescript

from mori (A library for using ClojureScript's persistent data structures in JS) the cljs data structures should be: list, vector, hashMap, set, sortedSet, range, queue

Comment 4

[jmckitrick]

(In reply to Nicolas Chevobbe [:nchevobbe] from comment #1)

I'd be happy to mentor anyone who wants to implement this.
The first thing to do would be to do an inventory of the different type of ClojureScript objects that can be rendered, so we can split that bug into multiple smaller ones for each type of object.

Sign me up! I’d love to help.

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

Sadly I won't have any time to dedicate to this

Comment 6

[Nicolas Chevobbe [:nchevobbe]]

Attachment: WIP: - Add onNativeCall extra allow list so CLJS devtools work

For some reason, it also seems that CLJS modified the devtoolsFormatters array
and sometimes it couldn't find the body hook to use based on the index.
So instead of sending the index, we store the formatter entry in the object actor,
so we can reuse it later when customFormatterBody is called.