Closed Bug 1642464 Opened 4 years ago Closed 4 years ago

Remove unused add search engine command handler from the searchbar

Categories

(Firefox :: Search, task, P2)

Product:
Firefox
Component:
Search
Type:
task
Points:
1

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 79
Iteration:
79.1 - June 1 - June 14
Tracking Flags:
Tracking Status
firefox79 --- fixed

People

(Reporter: standard8, Assigned: standard8)

Details

Attachments

(1 file)

Bug 1642464 - Remove unused command handler from the searchbar. r?adw!
47 bytes, text/x-phabricator-request
Details | Review

I noticed that the search bar has an unused command handler:

https://searchfox.org/mozilla-central/rev/8ccea36c4fb09412609fb738c722830d7098602b/browser/components/search/content/searchbar.js#467-475

This has been unused for a while (probably since we had a menu from the search bar). The search-one-offs use their own handler:

https://searchfox.org/mozilla-central/rev/8ccea36c4fb09412609fb738c722830d7098602b/browser/components/search/content/search-one-offs.js#1140-1175

Hence we can just remove it.

Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/06a66a93880e
Remove unused command handler from the searchbar. r=adw

https://hg.mozilla.org/mozilla-central/rev/06a66a93880e

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox79: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 79
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: