1642544 - Failure parsing vCard lines with one value when multiple values are expected

Status: RESOLVED FIXED

(MailNews Core :: Address Book, defect)

Description

[Geoff Lankow (:darktrojan)]

Some vCard properties can have a variable number of value, for example ORG can have an organisation and any number of organisation units. If there's only one value, ICAL.js parses that as a string when we're expecting an array and we get an error.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: 1642544-vcard-multiple-values-1.diff

Comment 2

[Geoff Lankow (:darktrojan)]

Marking this as a regression of bug 1639430 for tracking purposes, although I don't think the old parser could handle this either.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f00e8c7891ad
Correctly parse vCard lines that have only one value when multiple values are also valid. r=mkmelin

Comment 4

[Wayne Mery (:wsmwk)]

Comment on attachment 9153322 [details] [diff] [review]
1642544-vcard-multiple-values-1.diff

[Triage Comment]
Approved for beta

Comment 5

[Rob Lemley [:rjl]]

Thunderbird 78.0b1:
https://hg.mozilla.org/releases/comm-beta/rev/1a47d65e5ec7