Closed Bug 1642544 Opened 5 years ago Closed 5 years ago

Failure parsing vCard lines with one value when multiple values are expected

Categories

(MailNews Core :: Address Book, defect)

Product:
MailNews Core
Component:
Address Book
Type:
defect

Tracking

(thunderbird78 fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 79.0
Tracking Flags:
Tracking Status
thunderbird78 --- fixed

People

(Reporter: darktrojan, Assigned: darktrojan)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

1642544-vcard-multiple-values-1.diff
2.54 KB, patch
mkmelin
: review+
wsmwk
: approval-comm-beta+
Details | Diff | Splinter Review

Some vCard properties can have a variable number of value, for example ORG can have an organisation and any number of organisation units. If there's only one value, ICAL.js parses that as a string when we're expecting an array and we get an error.

Attachment #9153322 - Flags: review?(mkmelin+mozilla)
Attachment #9153322 - Flags: approval-comm-beta?

Marking this as a regression of bug 1639430 for tracking purposes, although I don't think the old parser could handle this either.

Regressed by: 1639430
Attachment #9153322 - Flags: review?(mkmelin+mozilla) → review+

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/f00e8c7891ad
Correctly parse vCard lines that have only one value when multiple values are also valid. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 79.0
Comment on attachment 9153322 [details] [diff] [review] 1642544-vcard-multiple-values-1.diff [Triage Comment] Approved for beta
Attachment #9153322 - Flags: approval-comm-beta? → approval-comm-beta+
Keywords: regression
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: