Failure parsing vCard TEL lines with multiple types specified
Categories
(MailNews Core :: Address Book, defect)
Tracking
(thunderbird78 fixed)
Tracking | Status | |
---|---|---|
thunderbird78 | --- | fixed |
People
(Reporter: darktrojan, Assigned: darktrojan)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file, 1 obsolete file)
3.17 KB,
patch
|
darktrojan
:
review+
wsmwk
:
approval-comm-beta+
|
Details | Diff | Splinter Review |
This is a valid vCard line, but we fail to parse it: TEL;TYPE=work,pref:11-2358-13-21
.
Assignee | ||
Comment 1•4 years ago
|
||
Also, while we're here, I've added storage of fax and pager numbers, which was missed before.
Comment 2•4 years ago
|
||
Comment on attachment 9153328 [details] [diff] [review] 1642546-vcard-tel-type-and-pref-1.diff Review of attachment 9153328 [details] [diff] [review]: ----------------------------------------------------------------- LGTM, r=mkmelin
Assignee | ||
Comment 3•4 years ago
|
||
My comment 0 was actually incorrect, TYPE=work,pref
is not valid. I think made a mistake copying something into my list of edge cases.
But it is valid to have multiple types, as TYPE=work,cell
or TYPE=work;TYPE=cell
, so the fix still matters. I've made a minor change to fix up a mistake (break
instead of continue
) and fixed up the test cases.
Assignee | ||
Comment 4•4 years ago
|
||
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/7ad149896c42
Fix failure parsing vCard TEL lines with multiple types specified. r=mkmelin
Assignee | ||
Updated•4 years ago
|
Comment 6•4 years ago
|
||
Comment on attachment 9153685 [details] [diff] [review] 1642546-vcard-tel-type-and-pref-2.diff [Triage Comment] Approved for beta
Updated•4 years ago
|
Comment 7•4 years ago
|
||
bugherder uplift |
Thunderbird 78.0b1:
https://hg.mozilla.org/releases/comm-beta/rev/bcf0deefc739
Updated•4 years ago
|
Description
•