Closed Bug 1642546 Opened 8 months ago Closed 8 months ago

Failure parsing vCard TEL lines with multiple types specified

Categories

(MailNews Core :: Address Book, defect)

defect

Tracking

(thunderbird78 fixed)

RESOLVED FIXED
Thunderbird 79.0
Tracking Status
thunderbird78 --- fixed

People

(Reporter: darktrojan, Assigned: darktrojan)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file, 1 obsolete file)

This is a valid vCard line, but we fail to parse it: TEL;TYPE=work,pref:11-2358-13-21.

Also, while we're here, I've added storage of fax and pager numbers, which was missed before.

Attachment #9153328 - Flags: review?(mkmelin+mozilla)
Attachment #9153328 - Flags: approval-comm-beta?
Comment on attachment 9153328 [details] [diff] [review]
1642546-vcard-tel-type-and-pref-1.diff

Review of attachment 9153328 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, r=mkmelin
Attachment #9153328 - Flags: review?(mkmelin+mozilla) → review+

My comment 0 was actually incorrect, TYPE=work,pref is not valid. I think made a mistake copying something into my list of edge cases.

But it is valid to have multiple types, as TYPE=work,cell or TYPE=work;TYPE=cell, so the fix still matters. I've made a minor change to fix up a mistake (break instead of continue) and fixed up the test cases.

Summary: Failure parsing vCard TEL lines with type and pref specified → Failure parsing vCard TEL lines with multiple types specified
Attachment #9153328 - Attachment is obsolete: true
Attachment #9153328 - Flags: approval-comm-beta?
Attachment #9153685 - Flags: review+
Attachment #9153685 - Flags: approval-comm-beta?

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/7ad149896c42
Fix failure parsing vCard TEL lines with multiple types specified. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 79.0
Comment on attachment 9153685 [details] [diff] [review]
1642546-vcard-tel-type-and-pref-2.diff

[Triage Comment]
Approved for beta
Attachment #9153685 - Flags: approval-comm-beta? → approval-comm-beta+
Keywords: regression
You need to log in before you can comment on or make changes to this bug.