1642546 - Failure parsing vCard TEL lines with multiple types specified

Status: RESOLVED FIXED

(MailNews Core :: Address Book, defect)

Description

[Geoff Lankow (:darktrojan)]

This is a valid vCard line, but we fail to parse it: TEL;TYPE=work,pref:11-2358-13-21.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: 1642546-vcard-tel-type-and-pref-1.diff

Also, while we're here, I've added storage of fax and pager numbers, which was missed before.

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 9153328 [details] [diff] [review]
1642546-vcard-tel-type-and-pref-1.diff

Review of attachment 9153328 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, r=mkmelin

Comment 3

[Geoff Lankow (:darktrojan)]

My comment 0 was actually incorrect, TYPE=work,pref is not valid. I think made a mistake copying something into my list of edge cases.

But it is valid to have multiple types, as TYPE=work,cell or TYPE=work;TYPE=cell, so the fix still matters. I've made a minor change to fix up a mistake (break instead of continue) and fixed up the test cases.

Comment 4

[Geoff Lankow (:darktrojan)]

Attachment: 1642546-vcard-tel-type-and-pref-2.diff

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/7ad149896c42
Fix failure parsing vCard TEL lines with multiple types specified. r=mkmelin

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9153685 [details] [diff] [review]
1642546-vcard-tel-type-and-pref-2.diff

[Triage Comment]
Approved for beta

Comment 7

[Rob Lemley [:rjl]]

Thunderbird 78.0b1:
https://hg.mozilla.org/releases/comm-beta/rev/bcf0deefc739